CHANGE: Update ci to use new Package Verification Profile to generate errors (#1965)

stefanunity · web-flow · commit 21726c7ef8be · 2024-07-18T15:44:19.000+02:00
* added new PVP execution to "Publish to Internal Registry (Dry Run)" yamato job * added .\yamato\PVPexemptions.json file that includes all the errors the package currently generates * any new errors will fail this job and you can see the report in the results tab of the job in yamato * our grandfathered exemptsions being added to the system at https://github.cds.internal.unity3d.com/unity/pets.pvp-catalog/pull/23 * also fixed 2 small error categories as part of this PR (trainling spaces, wrong meta files) * PVP-40-1 will complain about [Unreleased] in our changelog but won't be a problem on stable branch where that section will not exist during our package release
diff --git a/.yamato/PVPexemptions.json b/.yamato/PVPexemptions.json
diff --git a/.yamato/upm-ci.yml b/.yamato/upm-ci.yml
@@ -247,6 +247,9 @@ publish{% cycle "", "_dryrun" %}:
     - upm-ci package pack --package-path ./Packages/com.unity.inputsystem/
     - upm-ci package test --package-path ./Packages/com.unity.inputsystem/ -u 2019.4
     - upm-ci package publish --package-path ./Packages/com.unity.inputsystem/ {% cycle "", "--dry-run" %}
+    - upm-pvp xray --packages "upm-ci~/packages/*.tgz" --results upm-ci~/xray
+    - upm-pvp require "supported rme" --no-report --allow-missing --results upm-ci~/xray --exemptions upm-ci~/xray/new-exemptions.json
+    - upm-pvp require "supported rme ./.yamato/PVPexemptions.json" --allow-missing --results upm-ci~/xray    
   artifacts:
     artifacts:
       paths:
diff --git a/Assets/Samples/CustomComposite/.sample.json b/Assets/Samples/CustomComposite/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Custom Binding Composite",
   "description": "Shows how to implement a custom composite binding."
-} 
+}
diff --git a/Assets/Samples/CustomDevice/.sample.json b/Assets/Samples/CustomDevice/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Custom Device",
   "description": "Shows how to implement a custom input device."
-} 
+}
diff --git a/Assets/Samples/CustomDeviceUsages/.sample.json b/Assets/Samples/CustomDeviceUsages/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Custom Device Usages",
   "description": "Shows how to tag devices with custom usage strings that can be used, for example, to distinguish multiple instances of the same type of device (e.g. 'Gamepad') based on how the device is used (e.g. 'Player1' vs 'Player2' or 'LeftHand' vs 'RightHand')."
-} 
+}
diff --git a/Assets/Samples/CustomDeviceUsages/.sample.json.meta b/Assets/Samples/CustomDeviceUsages/.sample.json.meta
diff --git a/Assets/Samples/GamepadMouseCursor/.sample.json b/Assets/Samples/GamepadMouseCursor/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Gamepad Mouse Cursor",
   "description": "An example that shows how to use the gamepad for driving a mouse cursor for use with UIs."
-} 
+}
diff --git a/Assets/Samples/InGameHints/.sample.json b/Assets/Samples/InGameHints/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "In-Game Hints",
   "description": "Demonstrates how to create in-game hints in the UI which reflect current bindings and active control schemes."
-} 
+}
diff --git a/Assets/Samples/InputDeviceTester/.sample.json b/Assets/Samples/InputDeviceTester/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "InputDeviceTester",
   "description": "A scene containing UI to visualize the controls on various supported input devices."
-} 
+}
diff --git a/Assets/Samples/InputDeviceTester/.sample.json.meta b/Assets/Samples/InputDeviceTester/.sample.json.meta
diff --git a/Assets/Samples/InputRecorder/.sample.json b/Assets/Samples/InputRecorder/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Input Recorder",
   "description": "Shows how to capture and replay input events. Also useful by itself to debug input event sequences."
-} 
+}
diff --git a/Assets/Samples/OnScreenControls/.sample.json b/Assets/Samples/OnScreenControls/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "On-Screen Controls",
   "description": "Demonstrates a simple setup for an on-screen joystick."
-} 
+}
diff --git a/Assets/Samples/RebindingUI/.sample.json b/Assets/Samples/RebindingUI/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Rebinding UI",
   "description": "An example UI component that demonstrates how to create UI for rebinding actions."
-} 
+}
diff --git a/Assets/Samples/SimpleDemo/.sample.json b/Assets/Samples/SimpleDemo/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Simple Demo",
   "description": "A walkthrough of a simple character controller that demonstrates several techniques for working with the input system. See the README.md file in the sample for details."
-} 
+}
diff --git a/Assets/Samples/SimpleDemo/.sample.json.meta b/Assets/Samples/SimpleDemo/.sample.json.meta
diff --git a/Assets/Samples/SimpleMultiplayer/.sample.json b/Assets/Samples/SimpleMultiplayer/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Simple Multiplayer",
   "description": "Demonstrates how to set up a simple local multiplayer scenario."
-} 
+}
diff --git a/Assets/Samples/TouchSamples/.sample.json b/Assets/Samples/TouchSamples/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Touch Samples",
   "description": "A series of sample scenes for using touch input with the Input System package. This sample is not actually part of the package, but needs to be downloaded."
-} 
+}
diff --git a/Assets/Samples/UIvsGameInput/.sample.json b/Assets/Samples/UIvsGameInput/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "UI vs. Game Input",
   "description": "An example that shows how to deal with ambiguities that may arrise when overlaying interactive UI elements on top of a game scene."
-} 
+}
diff --git a/Assets/Samples/UnityRemote/.sample.json b/Assets/Samples/UnityRemote/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Unity Remote",
   "description": "An example with a simple scene for trying out the Unity Remote app."
-} 
+}
diff --git a/Assets/Samples/Visualizers/.sample.json b/Assets/Samples/Visualizers/.sample.json
@@ -1,4 +1,4 @@
 {
   "displayName": "Visualizers",
   "description": "Several example visualizations of input controls/devices and input actions."
-} 
+}
diff --git a/Packages/com.unity.inputsystem/CHANGELOG.md b/Packages/com.unity.inputsystem/CHANGELOG.md
@@ -23,6 +23,7 @@ however, it has to be formatted properly to pass verification tests.
 - Added warning messages to both `OnScreenStick` and `OnScreenButton` Inspector editors that would display a warning message in case on-screen control components are added to a `GameObject` not part of a valid UI hierarchy.
 - Changed behavior for internal feature flag relating to Windows Gaming Input to be ignored on non-supported platforms.
 - Changed `DualSenseHIDInputReport` from internal to public visibility
+- Added Input Setting option allowing to keep platform-specific scroll wheel input values instead of automatically converting them to a normalized range.
 
 ### Fixed
 - Avoid potential crashes from `NullReferenceException` in `FireStateChangeNotifications`.

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"displayName": "Custom Binding Composite",`
`3`	`3`	`"description": "Shows how to implement a custom composite binding."`
`4`		`-}`
	`4`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"displayName": "Custom Device",`
`3`	`3`	`"description": "Shows how to implement a custom input device."`
`4`		`-}`
	`4`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"displayName": "Custom Device Usages",`
`3`	`3`	`"description": "Shows how to tag devices with custom usage strings that can be used, for example, to distinguish multiple instances of the same type of device (e.g. 'Gamepad') based on how the device is used (e.g. 'Player1' vs 'Player2' or 'LeftHand' vs 'RightHand')."`
`4`		`-}`
	`4`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"displayName": "Gamepad Mouse Cursor",`
`3`	`3`	`"description": "An example that shows how to use the gamepad for driving a mouse cursor for use with UIs."`
`4`		`-}`
	`4`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"displayName": "In-Game Hints",`
`3`	`3`	`"description": "Demonstrates how to create in-game hints in the UI which reflect current bindings and active control schemes."`
`4`		`-}`
	`4`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`{`
`2`	`2`	`"displayName": "InputDeviceTester",`
`3`	`3`	`"description": "A scene containing UI to visualize the controls on various supported input devices."`
`4`		`-}`
	`4`	`+}`