FIX: interactions reset when performed is triggered by the cancelation the current active interaction (ISXB-310) (#1963)

* fixed interactions reset when performed is triggered by the cancelation the current active interaction

* fix doc and format

Author: bmalrat

Assets/Tests/InputSystem/CoreTests_Actions_Interactions.cs

@@ -231,6 +231,48 @@ public void Actions_WhenTransitioningFromOneInteractionToNext_GetCallbacks()
         }
     }
 
+    // https://jira.unity3d.com/browse/ISXB-310
+    [Test]
+    [Category("Actions")]
+    public void Actions_WhenTransitioningFromOneInteractionToNextAlreadyPerformed_GetCallbacksAndResetOtherInteractions()
+    {
+        ResetTime();
+
+        var gamepad = InputSystem.AddDevice<Gamepad>();
+
+        var action = new InputAction("test", InputActionType.Button, binding: "<Gamepad>/buttonSouth",
+            interactions: "multiTap(tapCount=3),multiTap,Tap");
+        action.Enable();
+
+        using (var trace = new InputActionTrace(action))
+        {
+            // Trigger the second interaction with a double tap which also internally performs a tap on the third one.
+            PressAndRelease(gamepad.buttonSouth);
+            PressAndRelease(gamepad.buttonSouth, 0.2);
+            currentTime = 2;
+            InputSystem.Update();
+            Assert.That(trace,
+                Started<MultiTapInteraction>(action, gamepad.buttonSouth, time: 0)
+                    .AndThen(Canceled<MultiTapInteraction>(action, gamepad.buttonSouth, duration: 2))
+                    .AndThen(Started<MultiTapInteraction>(action, gamepad.buttonSouth))
+                    .AndThen(Performed<MultiTapInteraction>(action, gamepad.buttonSouth, duration: 0.2)));
+
+            trace.Clear();
+
+            // Trigger the third interaction with a tap and ensure that doesn't come from the previous one.
+            PressAndRelease(gamepad.buttonSouth, time: 4);
+            currentTime = 6;
+            InputSystem.Update();
+            Assert.That(trace,
+                Started<MultiTapInteraction>(action, gamepad.buttonSouth, time: 4)
+                    .AndThen(Canceled<MultiTapInteraction>(action, gamepad.buttonSouth, duration: 2))
+                    .AndThen(Started<MultiTapInteraction>(action, gamepad.buttonSouth, time: 4))
+                    .AndThen(Canceled<MultiTapInteraction>(action, gamepad.buttonSouth, duration: 2))
+                    .AndThen(Started<TapInteraction>(action, gamepad.buttonSouth, time: 4))
+                    .AndThen(Performed<TapInteraction>(action, gamepad.buttonSouth, time: 4)));
+        }
+    }
+
     [Test]
     [Category("Actions")]
     public void Actions_CanPerformPressInteraction()

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -12,6 +12,7 @@ however, it has to be formatted properly to pass verification tests.
 
 ### Fixed
 - Fixed default scroll speed in uGUI being slower than before. [ISXB-766](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-766)
+- Fixed an issue when multiple interactions drive an action and perform during the cancelation of the current active interaction [ISXB-310](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-310).
 
 ### Added
 - Added `InputSystemUIInputModule.scrollDeltaPerTick` property, a customizable multiplicative factor applied to the scroll wheel speed before it is sent to UI components. Note that this has no effect on UI Toolkit content, only uGUI.

Packages/com.unity.inputsystem/Documentation~/Interactions.md

@@ -47,26 +47,27 @@ The following example demonstrates this kind of setup with a fire Action that th
 var fireAction = new InputAction("fire");
 fireAction.AddBinding("<Gamepad>/buttonSouth")
     // Tap fires, slow tap charges. Both act on release.
-    .WithInteractions("tap;slowTap");
+    .WithInteractions("tap,slowTap");
 
 fireAction.started +=
     context =>
     {
-        if (context.Interaction is SlowTapInteraction)
+        if (context.interaction is SlowTapInteraction)
             ShowChargingUI();
     };
 
 fireAction.performed +=
     context =>
     {
-        if (context.Interaction is SlowTapInteraction)
+        if (context.interaction is SlowTapInteraction)
             ChargedFire();
         else
             Fire();
     };
 
 fireAction.canceled +=
     _ => HideChargingUI();
+fireAction.Enable();
 ```
 
 ### Multiple Controls on an Action

Packages/com.unity.inputsystem/InputSystem/Actions/InputActionState.cs

@@ -2266,6 +2266,14 @@ internal void ChangePhaseOfInteraction(InputActionPhase newPhase, ref TriggerSta
                                 };
                                 if (!ChangePhaseOfAction(InputActionPhase.Performed, ref triggerForInteraction, phaseAfterPerformedOrCanceled))
                                     return;
+
+                                // We performed the action,
+                                // so reset remaining interaction to waiting state.
+                                for (; i < numInteractions; ++i)
+                                {
+                                    index = interactionStartIndex + i;
+                                    ResetInteractionState(index);
+                                }
                             }
                             break;
                         }