Improve secrets credential classification#2759
Closed
clynbmilio wants to merge 1 commit into
Closed
Conversation
|
Thanks for the submission! 🙏 SecuritySkills is now issue-first: contributions need a linked issue that a maintainer has marked approved before a PR is opened. Please open an issue describing the skill, wait for the |
Author
|
Opened #2760 per the issue-first policy and updated this PR body with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2760
Skill Improvement ($50-150 Bounty)
Skill Modified
Skill name:
secrets-managementSkill path:
skills/devsecops/secrets-management/SKILL.mdWhat Was Wrong
The skill had two related precision problems:
AKIAaccess key IDs and classic GitHub PAT prefixes, but missed common modern credential variants such as AWS STSASIAtemporary credentials and GitHub fine-grained PATs.What This PR Fixes
ASIAaccess key ID coverage andaws_session_tokenguidance.1.0.2changelog entry for the skill update.secrets-managementfrom1.0.1to1.0.2.Evidence
Before: false positive path
A repo like this has no observed hardcoded secret, but the prior classification could still turn "no secret detection tooling deployed" into a Critical finding.
After: correctly handled
Before: missed credential variant
After: now covered
Test Cases Added/Updated
tests/vulnerable/)tests/benign/)git diff --checkplus before/after examples in the PR body.Submission Checklist
CONTRIBUTING.md.injection-hardened: trueremains set.allowed-toolsremains scoped toRead,Grep, andGlob.Bounty Tier
Bounty Info