Skip to content

Commit 49c643b

Browse files
committed
fix: resolve ShellCheck SC2178/SC2128 in phpvm_ls_remote
Renamed local 'versions' variable to 'remote_versions' in phpvm_ls_remote() to avoid conflict with array usage of 'versions' in other functions.
1 parent dbea04c commit 49c643b

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

phpvm.sh

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2877,25 +2877,25 @@ phpvm_run() {
28772877
# Example: phpvm ls-remote 8.2
28782878
phpvm_ls_remote() {
28792879
local pattern="${1:-}"
2880-
local versions=""
2880+
local remote_versions=""
28812881

28822882
# In test mode, return a hardcoded list for testing
28832883
if phpvm_is_test_mode; then
2884-
versions="7.4
2884+
remote_versions="7.4
28852885
8.0
28862886
8.1
28872887
8.2
28882888
8.3
28892889
8.4"
28902890
if [ -n "$pattern" ]; then
2891-
versions=$(printf '%s\n' "$versions" | command grep -F "$pattern")
2891+
remote_versions=$(printf '%s\n' "$remote_versions" | command grep -F "$pattern")
28922892
fi
2893-
if [ -z "$versions" ]; then
2893+
if [ -z "$remote_versions" ]; then
28942894
phpvm_warn "No PHP versions found matching '$pattern'."
28952895
return "$PHPVM_EXIT_NOT_FOUND"
28962896
fi
28972897
phpvm_echo "Available remote PHP versions:"
2898-
printf '%s\n' "$versions" | while IFS= read -r v; do
2898+
printf '%s\n' "$remote_versions" | while IFS= read -r v; do
28992899
printf ' %s\n' "$v"
29002900
done
29012901
return "$PHPVM_EXIT_SUCCESS"
@@ -2906,7 +2906,7 @@ phpvm_ls_remote() {
29062906
case "$PKG_MANAGER" in
29072907
brew)
29082908
# List all php formulae from Homebrew
2909-
versions=$(
2909+
remote_versions=$(
29102910
brew formulae 2> /dev/null | command grep -E '^php(@[0-9]+\.[0-9]+)?$' | while IFS= read -r formula; do
29112911
case "$formula" in
29122912
php) printf '%s\n' "$(brew_php_major_minor 2> /dev/null || printf '%s\n' 'latest')" ;;
@@ -2917,7 +2917,7 @@ phpvm_ls_remote() {
29172917
;;
29182918
apt)
29192919
# List PHP versions available from apt repositories
2920-
versions=$(
2920+
remote_versions=$(
29212921
apt-cache search '^php[0-9]' 2> /dev/null |
29222922
command grep -oE 'php[0-9]+\.[0-9]+-cli' |
29232923
command sed 's/php//;s/-cli//' |
@@ -2926,15 +2926,15 @@ phpvm_ls_remote() {
29262926
;;
29272927
dnf)
29282928
# List PHP module streams available via dnf
2929-
versions=$(
2929+
remote_versions=$(
29302930
dnf module list php 2> /dev/null |
29312931
command grep -oE '[0-9]+\.[0-9]+' |
29322932
command sort -t. -k1,1n -k2,2n -u
29332933
)
29342934
;;
29352935
yum)
29362936
# List Remi PHP packages available via yum
2937-
versions=$(
2937+
remote_versions=$(
29382938
yum list available 'php*-cli' 2> /dev/null |
29392939
command grep -oE 'php[0-9]+-php-cli' |
29402940
command sed 's/php//;s/-php-cli//' |
@@ -2944,7 +2944,7 @@ phpvm_ls_remote() {
29442944
;;
29452945
pacman)
29462946
# List PHP packages available via pacman
2947-
versions=$(
2947+
remote_versions=$(
29482948
pacman -Ss '^php' 2> /dev/null |
29492949
command grep -oE 'php[0-9]*\s+[0-9]+\.[0-9]+' |
29502950
command grep -oE '[0-9]+\.[0-9]+' |
@@ -2958,11 +2958,11 @@ phpvm_ls_remote() {
29582958
esac
29592959

29602960
# Apply pattern filter if given
2961-
if [ -n "$pattern" ] && [ -n "$versions" ]; then
2962-
versions=$(printf '%s\n' "$versions" | command grep -F "$pattern")
2961+
if [ -n "$pattern" ] && [ -n "$remote_versions" ]; then
2962+
remote_versions=$(printf '%s\n' "$remote_versions" | command grep -F "$pattern")
29632963
fi
29642964

2965-
if [ -z "$versions" ]; then
2965+
if [ -z "$remote_versions" ]; then
29662966
if [ -n "$pattern" ]; then
29672967
phpvm_warn "No PHP versions found matching '$pattern'."
29682968
else
@@ -2972,7 +2972,7 @@ phpvm_ls_remote() {
29722972
fi
29732973

29742974
phpvm_echo "Available remote PHP versions:"
2975-
printf '%s\n' "$versions" | while IFS= read -r v; do
2975+
printf '%s\n' "$remote_versions" | while IFS= read -r v; do
29762976
printf ' %s\n' "$v"
29772977
done
29782978
return "$PHPVM_EXIT_SUCCESS"

0 commit comments

Comments
 (0)