fix: update environment variable names for debug logging consistency

Author: Thavarshan

.github/copilot-instructions.md

@@ -43,6 +43,6 @@ Conventions: tag = `X.Y.Z` (no `v` prefix), title = `vX.Y.Z` (with `v` prefix).
 
 - `PHPVM_DIR` — Installation directory (default: `~/.phpvm`)
 - `PHPVM_TEST_MODE` — Enable test/mock mode
-- `DEBUG` — Enable debug logging
+- `PHPVM_DEBUG` — Enable debug logging
 - `PHPVM_AUTO_USE` — Enable automatic `.phpvmrc` detection
 - `PHPVM_PHPVMRC_MAX_DEPTH` — Max parent directory traversal for `.phpvmrc` (default: 25)

CLAUDE.md

@@ -70,7 +70,7 @@ The tool detects and works with multiple package managers:
 - ShellCheck static analysis for code quality
 
 ### Debugging
-- Enable debug mode: `DEBUG=true phpvm <command>`
+- Enable debug mode: `PHPVM_DEBUG=true phpvm <command>`
 - Debug logs provide detailed execution tracing
 - Test mode can be enabled with `PHPVM_TEST_MODE=true`
 
@@ -100,11 +100,11 @@ bats tests/
 bats tests/01_core.bats
 
 # Enable debug mode for troubleshooting
-DEBUG=true bats tests/
+PHPVM_DEBUG=true bats tests/
 
 # Test specific functionality manually with test mode
-PHPVM_TEST_MODE=true DEBUG=true ./phpvm.sh install 8.1
-PHPVM_TEST_MODE=true DEBUG=true ./phpvm.sh use 8.1
+PHPVM_TEST_MODE=true PHPVM_DEBUG=true ./phpvm.sh install 8.1
+PHPVM_TEST_MODE=true PHPVM_DEBUG=true ./phpvm.sh use 8.1
 
 # Check shell syntax
 bash -n phpvm.sh
@@ -177,7 +177,7 @@ phpvm/
 ## Environment Variables
 
 - `PHPVM_DIR` - Installation directory (default: `~/.phpvm`)
-- `DEBUG` - Enable debug logging (set to `true`)
+- `PHPVM_DEBUG` - Enable debug logging (set to `true`)
 - `PHPVM_TEST_MODE` - Enable test mode (set to `true`)
 - `PHPVM_SOURCED` - Control execution vs sourcing behavior
 - `PHPVM_AUTO_USE` - Enable automatic `.phpvmrc` detection (default: `true`)

README.md

@@ -95,24 +95,24 @@ If the installation was successful, it should output the path to `phpvm`.
 
 ### Available Commands
 
-| Command                     | Description                                |
-| --------------------------- | ------------------------------------------ |
-| `phpvm install [version]`   | Install a PHP version (reads `.phpvmrc` if no version given) |
+| Command                     | Description                                                               |
+| --------------------------- | ------------------------------------------------------------------------- |
+| `phpvm install [version]`   | Install a PHP version (reads `.phpvmrc` if no version given)              |
 | `phpvm use [version]`       | Switch PHP version (reads `.phpvmrc` → default alias if no version given) |
-| `phpvm uninstall <version>` | Remove a specific PHP version              |
-| `phpvm current`             | Display the currently active PHP version   |
-| `phpvm which [version]`     | Show the path to PHP binary for a version  |
-| `phpvm deactivate`          | Temporarily disable phpvm and restore PATH |
-| `phpvm system`              | Switch to system/Homebrew default PHP      |
-| `phpvm auto`                | Auto-switch based on `.phpvmrc` file       |
-| `phpvm list` or `phpvm ls`  | List all installed PHP versions            |
-| `phpvm alias [name] [ver]`  | Create, update, or list version aliases    |
-| `phpvm unalias <name>`      | Remove version alias                       |
-| `phpvm cache dir`           | Show phpvm cache directory                 |
-| `phpvm info`                | Show system information for debugging      |
-| `phpvm version`             | Show version information                   |
-| `phpvm --version` / `-v`    | Show version information (aliases)         |
-| `phpvm help`                | Show help message                          |
+| `phpvm uninstall <version>` | Remove a specific PHP version                                             |
+| `phpvm current`             | Display the currently active PHP version                                  |
+| `phpvm which [version]`     | Show the path to PHP binary for a version                                 |
+| `phpvm deactivate`          | Temporarily disable phpvm and restore PATH                                |
+| `phpvm system`              | Switch to system/Homebrew default PHP                                     |
+| `phpvm auto`                | Auto-switch based on `.phpvmrc` file                                      |
+| `phpvm list` or `phpvm ls`  | List all installed PHP versions                                           |
+| `phpvm alias [name] [ver]`  | Create, update, or list version aliases                                   |
+| `phpvm unalias <name>`      | Remove version alias                                                      |
+| `phpvm cache dir`           | Show phpvm cache directory                                                |
+| `phpvm info`                | Show system information for debugging                                     |
+| `phpvm version`             | Show version information                                                  |
+| `phpvm --version` / `-v`    | Show version information (aliases)                                        |
+| `phpvm help`                | Show help message                                                         |
 
 ### Installing PHP Versions
 
@@ -341,7 +341,7 @@ fi
 | `PHPVM_DIR`               | `~/.phpvm` | Installation directory                                           |
 | `PHPVM_AUTO_USE`          | `true`     | Enable automatic `.phpvmrc` detection when sourced               |
 | `PHPVM_PHPVMRC_MAX_DEPTH` | `25`       | Max parent directories to traverse when searching for `.phpvmrc` |
-| `DEBUG`                   | `false`    | Enable debug logging with timestamps                             |
+| `PHPVM_DEBUG`             | `false`    | Enable debug logging with timestamps                             |
 | `NO_COLOR`                | _(unset)_  | Disable color output ([no-color.org](https://no-color.org/))     |
 | `PHPVM_LOG_TIMESTAMPS`    | `false`    | Always show timestamps in log output                             |
 
@@ -518,15 +518,15 @@ bats tests/01_core.bats
 ./phpvm.sh info
 
 # Test with debug output
-DEBUG=true ./phpvm.sh version
+PHPVM_DEBUG=true ./phpvm.sh version
 ```
 
 ### Debugging
 
-To enable debug output, set the `DEBUG` environment variable to `true`:
+To enable debug output, set the `PHPVM_DEBUG` environment variable to `true`:
 
 ```sh
-DEBUG=true phpvm install 8.1
+PHPVM_DEBUG=true phpvm install 8.1
 ```
 
 ## Maintainers

install.sh

@@ -103,15 +103,20 @@
         PROFILE="$(phpvm_detect_profile)"
 
         if [ -n "$PROFILE" ]; then
-            phpvm_echo "Adding phpvm to $PROFILE"
-
-            # Check shell type and use appropriate syntax
-            if echo "$PROFILE" | grep -q "zsh"; then
-                # For zsh - use proper if statement to prevent shell crash
-                printf "\nexport PHPVM_DIR=\"%s\"\nexport PATH=\"\$PHPVM_DIR/bin:\$PATH\"\nif [[ -s \"\$PHPVM_DIR/phpvm.sh\" ]]; then\n  source \"\$PHPVM_DIR/phpvm.sh\"\nfi\n" "$(phpvm_install_dir)" >> "$PROFILE"
+            # Check if phpvm is already configured in the profile
+            if grep -qF 'PHPVM_DIR' "$PROFILE" 2>/dev/null; then
+                phpvm_echo "phpvm already configured in $PROFILE (skipping)"
             else
-                # For bash and others - use POSIX compatible syntax
-                printf "\nexport PHPVM_DIR=\"%s\"\nexport PATH=\"\$PHPVM_DIR/bin:\$PATH\"\n[ -s \"\$PHPVM_DIR/phpvm.sh\" ] && . \"\$PHPVM_DIR/phpvm.sh\"\n" "$(phpvm_install_dir)" >> "$PROFILE"
+                phpvm_echo "Adding phpvm to $PROFILE"
+
+                # Check shell type and use appropriate syntax
+                if echo "$PROFILE" | grep -q "zsh"; then
+                    # For zsh - use proper if statement to prevent shell crash
+                    printf "\nexport PHPVM_DIR=\"%s\"\nexport PATH=\"\$PHPVM_DIR/bin:\$PATH\"\nif [[ -s \"\$PHPVM_DIR/phpvm.sh\" ]]; then\n  source \"\$PHPVM_DIR/phpvm.sh\"\nfi\n" "$(phpvm_install_dir)" >> "$PROFILE"
+                else
+                    # For bash and others - use POSIX compatible syntax
+                    printf "\nexport PHPVM_DIR=\"%s\"\nexport PATH=\"\$PHPVM_DIR/bin:\$PATH\"\n[ -s \"\$PHPVM_DIR/phpvm.sh\" ] && . \"\$PHPVM_DIR/phpvm.sh\"\n" "$(phpvm_install_dir)" >> "$PROFILE"
+                fi
             fi
         else
             phpvm_warn "Could not detect profile file. Please manually add the following to your shell profile:"

tests/04_lifecycle.bats

@@ -0,0 +1,100 @@
+#!/usr/bin/env bats
+# BATS test suite for phpvm - Full lifecycle tests (install → use → current → which → uninstall)
+
+bats_require_minimum_version 1.5.0
+
+load test_helper
+
+@test "lifecycle: install creates mock PHP directory" {
+    run install_php "8.2"
+    [ "$status" -eq 0 ]
+    [[ "$output" =~ "Installing PHP 8.2" ]]
+    [[ "$output" =~ "PHP 8.2 installed" ]]
+
+    # Verify mock directory was created
+    [ -d "$(phpvm_test_php_cellar_dir "8.2")" ]
+    [ -x "$(phpvm_test_php_path "8.2")" ]
+}
+
+@test "lifecycle: use switches to installed version" {
+    install_php "8.2"
+    run use_php_version "8.2"
+    [ "$status" -eq 0 ]
+    [[ "$output" =~ "Switched to PHP 8.2" ]]
+
+    # Active version file should be updated
+    [ -f "$PHPVM_ACTIVE_VERSION_FILE" ]
+    [ "$(cat "$PHPVM_ACTIVE_VERSION_FILE")" = "8.2" ]
+}
+
+@test "lifecycle: current shows active version after use" {
+    install_php "8.2"
+    use_php_version "8.2"
+    run phpvm_current
+    [ "$status" -eq 0 ]
+    [ "$output" = "8.2" ]
+}
+
+@test "lifecycle: which returns binary path for installed version" {
+    install_php "8.2"
+    use_php_version "8.2"
+    run phpvm_which "8.2"
+    [ "$status" -eq 0 ]
+    [[ "$output" =~ "php@8.2" ]]
+    [[ "$output" =~ "/bin/php" ]]
+}
+
+@test "lifecycle: use system sets active version to system" {
+    install_php "8.2"
+    use_php_version "8.2"
+    run use_php_version "system"
+    [ "$status" -eq 0 ]
+    [[ "$output" =~ "Switched to system PHP" ]]
+
+    [ "$(cat "$PHPVM_ACTIVE_VERSION_FILE")" = "system" ]
+}
+
+@test "lifecycle: uninstall removes mock PHP directory" {
+    install_php "8.1"
+    run uninstall_php "8.1"
+    [ "$status" -eq 0 ]
+    [[ "$output" =~ "PHP 8.1 uninstalled" ]]
+
+    # Mock directory should be removed
+    [ ! -d "$(phpvm_test_php_cellar_dir "8.1")" ]
+}
+
+@test "lifecycle: use fails for uninstalled version" {
+    run use_php_version "7.4"
+    [ "$status" -eq 4 ]
+    [[ "$output" =~ "not installed" ]]
+}
+
+@test "lifecycle: install then use then install another then switch" {
+    install_php "8.1"
+    use_php_version "8.1"
+    [ "$(cat "$PHPVM_ACTIVE_VERSION_FILE")" = "8.1" ]
+
+    install_php "8.2"
+    use_php_version "8.2"
+    [ "$(cat "$PHPVM_ACTIVE_VERSION_FILE")" = "8.2" ]
+
+    run phpvm_current
+    [ "$output" = "8.2" ]
+}
+
+@test "lifecycle: install with X.Y.Z normalizes to X.Y" {
+    run install_php "8.2.15"
+    [ "$status" -eq 0 ]
+    [[ "$output" =~ "Installing PHP 8.2" ]]
+    [ -d "$(phpvm_test_php_cellar_dir "8.2")" ]
+}
+
+@test "lifecycle: list shows installed versions" {
+    install_php "8.1"
+    install_php "8.2"
+    run list_installed_versions
+    [ "$status" -eq 0 ]
+    [[ "$output" =~ "8.1" ]]
+    [[ "$output" =~ "8.2" ]]
+}