chore(ci): split publish into release + prerelease jobs to mirror MongoDB#47
Merged
Conversation
…DB pipeline - Replace single `publish` job with two top-level jobs (`release`, `prerelease`) so the CI summary shows which path ran on each build (release on push to master, prerelease on PR — the other appears as `skipped`). - Add `pull-requests: write` permission and the "Comment released version on merged PR" step that posts the NuGet release link back to the merging PR. - Inline the per-job version computation (stable in release, pre in prerelease) instead of one combined block with shell branching. No change to the build/security jobs, version scheme, warning threshold, test filter, or package list.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns Cache's
build.ymlwith MongoDB'sbuild.ymlso the CI run summary shows which publish path took:publishjob with internal branching → onlypublishin the run summaryrelease(push to master) andprerelease(PR) jobs → both appear in every run, one runs and the other isskippedAlso brings over the "Comment released version on merged PR" step that parses the PR# from the merge-commit message and posts the GitHub Release link back to the merging PR.
Changes
publishinto top-levelrelease(master push, envrelease) andprerelease(PR, envprerelease) jobspull-requests: writepermission (needed bygh pr comment)releaseUnchanged: build/security jobs,
MAJOR_MINOR='0.4', warning threshold (10), test filter ((Category!=Integration)&(Category!=TimeCritical)), package list, NuGet/GitHub Release scripting.Test plan
build→security→prereleaseran,releaseskipped)build→security→releaseran (with PR comment),prereleaseskippedOut of scope (separate concern)
MAJOR_MINOR='0.4'means published versions are0.4.X, butTharga.Cache.csprojis at<Version>1.1.0</Version>. CI overrides via-p:PackageVersion=..., so .csproj is decorative at publish time. Worth deciding whether to bumpMAJOR_MINOR(e.g. to1.1) so the published series matches the .csproj — but that's a release-versioning policy decision, not a CI topology one.