fix(blazor): cache content panel readable in dark Radzen themes#44
Merged
Conversation
The JSON `<pre>` in CacheContent.razor was hardcoded to background:#f5f5f5, which renders white-on-white in dark Radzen themes. Switched to var(--rz-base) for the panel background and var(--rz-text-color) for the text so the panel adapts to the active theme. Reported by Quilt4Net.Server. Bundled NuGet bumps (per the session-start NuGet check): - Tharga.Blazor 2.1.4 -> 2.1.5 (same project being modified). - Tharga.MongoDB 2.10.9 -> 2.10.10 (clears NU1902/NU1903 transitive vulnerability advisories from SharpCompress 0.30.1 and Snappier 1.0.0; warning count back from 21 to 1). Build clean (1 pre-existing CS0162); 453 tests pass.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reported by Quilt4Net.Server: with a dark Radzen theme active (e.g. Humanistic Dark), the cache item JSON panel on
/developer/cacherendered white-on-white because the<pre>had a hardcoded light background.Fix: replace the inline
background:#f5f5f5withvar(--rz-base)and addcolor:var(--rz-text-color)so the panel adapts to whichever Radzen theme is active.Bundled NuGet bumps
While the feature was open, the session-start NuGet check turned up:
Tharga.Blazor2.1.4 → 2.1.5 inTharga.Cache.Blazor(same project being modified, low-risk patch).Tharga.MongoDB2.10.9 → 2.10.10 inTharga.Cache.MongoDB. This one mattered: the previous version pulled in transitively-vulnerableSharpCompress 0.30.1(NU1902, moderate) andSnappier 1.0.0(NU1903, high). After the bump, the build's warning count drops from 21 → 1.Tharga.Console3.7.4 → 4.0.0 was deliberately skipped (major bump, sample is intentionally pinned to 3.7.x).Test plan
Tharga.Cache.BlazorServersample on a dark Radzen theme and confirm the JSON panel is legible.