feat(optee): Update RPMB sections to be shown for AM62L#662
Open
jsuhaas22 wants to merge 1 commit intoTexasInstruments:masterfrom
Open
feat(optee): Update RPMB sections to be shown for AM62L#662jsuhaas22 wants to merge 1 commit intoTexasInstruments:masterfrom
jsuhaas22 wants to merge 1 commit intoTexasInstruments:masterfrom
Conversation
f3e302c to
c68d414
Compare
shiva-ti
previously approved these changes
Apr 14, 2026
cshilwant
previously approved these changes
Apr 14, 2026
StaticRocket
requested changes
Apr 14, 2026
| TVM | ||
| Trixie | ||
| UniFlash | ||
| userland |
Member
There was a problem hiding this comment.
I don't believe we should recognize userland as a word. User space is substantially more common and marginally more recognized.
| device has its own HUK signing key (DKEK), which is different from | ||
| other HS devices. TI SDK disables RPMB by-default. To enable it, | ||
| re-compiling OP-TEE with ``CFG_RPMB_FS=y`` flag. | ||
| RPMB works in TI SoCs with HS configuration. These embed a KEK |
Member
There was a problem hiding this comment.
KEK and DKEK acronyms are never actually defined.
Comment on lines
113
to
114
Member
There was a problem hiding this comment.
You could make vale happy by doing the following:
Suggested change
| Rich Execution Environment Filesystem (REE FS) and Replay Protected Memory Block (RPMB). |
| There is a hybrid mode in which both the flags i.e `CFG_REE_FS=y` and `CFG_RPMB_FS=y` are enabled. | ||
| This mode stores the state of the Secure Storage directory in RPMB partition to check for the | ||
| integrity of the data present in it. It is the recommended way. | ||
| There is a hybrid mode, which enables both `CFG_REE_FS=y` and `CFG_RPMB_FS=y`. |
Member
There was a problem hiding this comment.
Suggested change
| There is a hybrid mode, which enables both `CFG_REE_FS=y` and `CFG_RPMB_FS=y`. | |
| There is a hybrid mode, which enables both ``CFG_REE_FS=y`` and ``CFG_RPMB_FS=y``. |
| OPTEE-client also needs to be updated to enable the use of real | ||
| emmc instead of the virtual emmc that is enabled by default | ||
| Also update optee-client to enable the use of real | ||
| emmc instead of the virtual emmc, which is the default option. |
Member
There was a problem hiding this comment.
Suggested change
| emmc instead of the virtual emmc, which is the default option. | |
| eMMC instead of the virtual eMMC, which is the default option. |
c68d414 to
c87bafe
Compare
Collaborator
Author
|
Addressed your comments @StaticRocket |
So far, RPMB sections were excluded from AM62L docs since AM62L was not supporting RPMB. But now it does support. Therefore show those sections for AM62L as well. Also fix a few vale warnings. Signed-off-by: Suhaas Joshi <s-joshi@ti.com>
c87bafe to
2719315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, RPMB sections were excluded from AM62L docs since AM62L was not supporting RPMB. But now it does support. Therefore show those sections for AM62L as well.