fix(ios): prevent crash in SQL syntax highlighter with stale range#689
Merged
fix(ios): prevent crash in SQL syntax highlighter with stale range#689
Conversation
The highlight method is called asynchronously from the text storage delegate. By the time it executes, the text may have changed, making the editedRange invalid (location beyond string length). Add bounds check and clamp the range before calling lineRangeForRange. Fixes crash: -[NSString lineRangeForRange:] out-of-bounds exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
SQLSyntaxHighlighter.highlight(_:in:)that affected 5 TestFlight users.Root cause: The highlight method is called via
DispatchQueue.main.asyncfrom theNSTextStorageDelegate. By the time it executes, the text may have changed, making theeditedRangeparameter stale (location beyond current string length). This causes-[NSString lineRangeForRange:]to throw an out-of-bounds exception.Fix:
guard editedRange.location < fullLengthearly returneditedRange.lengthto not exceed string boundsCrash log
5 occurrences on iPhone 15, iOS 26.4.1, Build 6.