I have made some changes to file#466
Open
BrightHeart23 wants to merge 4 commits into
Open
Conversation
Contributor
|
Hi @BrightHeart23 Kindly resolve conflicts |
|
@BrightHeart23 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@BrightHeart23 kindly resolve the errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132
Closes #154
Refactored the real-time websocket gateway:
Renamed EscrowGateway to EventsGateway in escrow.gateway.ts
Added /events namespace and improved socket room management using Set for user and escrow mappings
Added reconnect handling and clearer join/leave logic for escrow rooms
Added helper emitToEscrowRoom(...) to centralize event emission
Modularized gateway configuration:
Created events.module.ts
Registered EventsModule in app.module.ts
Injected EventsModule into escrow.module.ts and notifications.module.ts
Integrated real-time event publishing into escrow flows:
Updated escrow.service.ts
Broadcast status changes, condition fulfillment/confirmation, dispute filed/resolved, and expiration events via EventsGateway
Added notification broadcasting:
Updated notifications.service.ts
Emit notification.new through EventsGateway when notifications are created
Added test coverage for websocket authentication and event broadcasting:
New spec file escrow.gateway.spec.ts