fix: media count/search, create-folder, plugin sidebar/prune, save-in-place, viewer scope, stable block IDs (#888 #890 #929 #970 #971 #835 #783 #931) by lane711 · Pull Request #983 · SonicJs-Org/sonicjs

lane711 · 2026-06-30T22:35:47Z

Summary

Media library "All Files" count shows the page size (24), not the library total #888 — "All Files" count showed page size (24) not real total; hasNextPage wrong. MediaDocumentService.list() now runs parallel COUNT(*) and returns total.
"Select Media" picker: search nests a new panel per keystroke and does not filter #890 — Media picker search did nothing + nested panel per keystroke. Fixed with name=\"search\" + hx-swap=\"outerHTML\" + hx-select=\"#media-selector-grid\".
[v3 bug]: Create folder action error #929 — Create folder errored on greenfield installs (legacy media table absent). Replaced with documents query + graceful catch.
[3.0.0-beta.17] SonicJSConfig disabled plugins show in Sidebar #971 — Disabled plugins still appeared in sidebar. Singleton menu items never DB-checked for active status. Fixed by tagging entries with pluginId and batch-querying active status in pluginMenuMiddleware.
[3.0.0-beta.17] SonicJSConfig plugins register uninstall plugin #970 — Plugins removed from config.plugins.register stayed installed+enabled. Added pruneStaleUserPlugins() in wireRegisteredPlugins Phase D: deactivates active non-core plugin documents absent from the current wired-plugin set, running fire-and-forget on first-request boot.
Improve content edit actions so users can save without leaving the page #835 — Save/Update always navigated away. Replaced with Save (inline success banner), Save & close (navigates to list), Publish (stays on page).
User scope is not working as expected #783 — Viewer role (default for new users) saw all sidebar items. Role guards added to both catalyst and v2 layouts: viewer sees Content + Collections; editor adds Settings; admin sees everything.
Add stable persisted IDs for block-array items #931 — Blocks in arrays had no stable ID. parseBlocksValue now assigns blockId: \"blk_<12hex>\" on first save and preserves existing IDs on reorder/edit/re-save. Existing content is backfilled on next write.

Test plan

🤖 Generated with Claude Code

- MediaDocumentService.list() now runs a parallel COUNT(*) with the same WHERE filters and returns `total` in MediaListResult - Admin media route uses `total` for totalFiles and fixes hasNextPage (was capped at page size 24 instead of real library total) - Media selector search input: add missing `name="search"` attr so the typed term is actually sent with the HTMX request - Add hx-swap="outerHTML" + hx-select="#media-selector-grid" to prevent the full panel (search box + grid) from nesting inside the grid on each keystroke Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…-triage

…le (#929) The /api/media/create-folder handler queried `SELECT COUNT(*) FROM media` to check for duplicates. On greenfield document-model installs the legacy `media` table does not exist, causing a D1 error on every folder creation. Replace the check with a query against `documents` (media_asset type) and wrap in try/catch so installs mid-migration (table absent) degrade gracefully rather than hard-erroring. Folders remain virtual in R2 — the check is advisory only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Singleton menu items (user plugins in config.plugins.register) were appended to the admin sidebar without checking DB active-status. A plugin disabled via the admin UI left its document status=inactive but the menu entry still rendered because only PLUGIN_REGISTRY items were DB-checked. Fix: - PluginMenuEntry / ResolvedPluginMenuEntry gain optional `pluginId` - app.ts tags every singleton menu entry with its parent plugin's id - plugin-menu middleware queries documents for active status of singleton plugin ids (one batch query) and filters inactive plugins out - Items without a pluginId (legacy/external) continue to render as before Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

When a plugin is removed from SonicJSConfig.plugins.register it previously stayed active in the documents table indefinitely (active-status plugin documents are never pruned). Add pruneStaleUserPlugins() called from wireRegisteredPlugins Phase D: - Queries all active non-core plugin documents (isCore falsy) - Any whose slug is absent from the current wired-plugin set is deactivated (json_set data.status = 'inactive', updated_at bumped) - Core plugins (isCore = true, bootstrapped by PluginBootstrapService) are never pruned; any per-row failure is non-fatal - Runs fire-and-forget alongside reflectWiredPlugins on first request Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…sh (#835) Replace the Update / Update & Publish button pair with three actions: - **Save** (action=save): saves draft, returns inline success banner via HTMX, user stays on the edit page - **Save & close** (action=save_and_close): saves draft, HX-Redirect to the content list (or the referrer URL if present) - **Publish** (action=save_and_publish): saves + publishes, returns inline success banner, user stays on the edit page Cancel still navigates to the content list unchanged. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…-triage

…oles (#783) Viewer role (default for new users) now sees only Content and Collections. Editor role sees Content, Collections, Settings but not Users or Plugins. Admin role unchanged — all items visible. Both catalyst and v2 layouts updated with consistent role guards. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Each block in a discriminated array gets a persisted `blockId` (e.g. `blk_aabbccddeeff`) generated once at first save. Re-parsing existing blocks preserves the ID, so reorder/edit cycles are stable. Backfill is automatic: any block saved without an ID receives one on next write. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…gler.toml (#928) db-reset.js now checks wrangler.toml → wrangler.jsonc → wrangler.json in order. DB ID/name update uses TOML regex for .toml files and JSON regex for .jsonc/.json. generate-cron-triggers.ts gracefully skips cron codegen when jsonc/json detected (triggers section is TOML-only by design). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…#643) #632: Remove dead drizzle-kit/drizzle-orm devDependencies and db:studio script from my-sonicjs-app. No drizzle.config exists; document model uses raw SQL. Script threw on every invocation. #643: Add format hint text below date (YYYY-MM-DD) and datetime (YYYY-MM-DD HH:MM) inputs in dynamic-field template so users know the expected entry format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Adds opt-in field projection to all collection read endpoints: GET /api/:collection GET /api/:collection/:id GET /api/content GET /api/content/:id Usage: ?fields=id,title,slug — top-level fields only ?fields=id,title,data.excerpt — mix top-level + data sub-fields ?fields=data — entire data blob Existing callers without ?fields= are unaffected. Cache is bypassed when projection is active (projected shape must not be stored as the canonical cached response). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

lane711 and others added 6 commits June 30, 2026 10:48

Merge remote-tracking branch 'origin/main' into lane711/v3-beta-issue…

6824feb

…-triage

lane711 temporarily deployed to internal July 1, 2026 01:52 — with GitHub Actions Inactive

lane711 changed the title ~~fix: media count, selector search, create-folder, disabled plugin sidebar (#888 #890 #929 #971)~~ fix: media count/search, create-folder, plugin sidebar/prune, save-in-place (#888 #890 #929 #970 #971 #835) Jul 1, 2026

Merge remote-tracking branch 'origin/main' into lane711/v3-beta-issue…

266f92b

…-triage

lane711 temporarily deployed to internal July 1, 2026 17:17 — with GitHub Actions Inactive

lane711 changed the title ~~fix: media count/search, create-folder, plugin sidebar/prune, save-in-place (#888 #890 #929 #970 #971 #835)~~ fix: media count/search, create-folder, plugin sidebar/prune, save-in-place, viewer scope (#888 #890 #929 #970 #971 #835 #783) Jul 1, 2026

lane711 temporarily deployed to internal July 1, 2026 19:26 — with GitHub Actions Inactive

lane711 temporarily deployed to internal July 1, 2026 20:34 — with GitHub Actions Inactive

lane711 temporarily deployed to internal July 1, 2026 21:49 — with GitHub Actions Inactive

lane711 temporarily deployed to internal July 1, 2026 23:25 — with GitHub Actions Inactive

lane711 temporarily deployed to internal July 2, 2026 21:51 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: media count/search, create-folder, plugin sidebar/prune, save-in-place, viewer scope, stable block IDs (#888 #890 #929 #970 #971 #835 #783 #931)#983

fix: media count/search, create-folder, plugin sidebar/prune, save-in-place, viewer scope, stable block IDs (#888 #890 #929 #970 #971 #835 #783 #931)#983
lane711 wants to merge 12 commits into
mainfrom
lane711/v3-beta-issue-triage

lane711 commented Jun 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

lane711 commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

lane711 commented Jun 30, 2026 •

edited

Loading