Update supported Symfony version to 8+#125
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the platform’s dependency constraints and related code/tests to support Symfony 8.1+ (and PHP 8.4+), aligning internal tooling output (PHPStan baseline, snapshots) with the upgraded ecosystem.
Changes:
- Bump PHP minimum to 8.4 and Symfony component constraints to ^8.1 (plus related vendor packages such as scheb/2fa and Symfony UX).
- Apply compatibility/formatting adjustments across Platform/SaaS bundles and tests (imports, minor syntax tweaks, kernel changes).
- Refresh tooling artifacts (PHPStan baseline, Rector/ECS config) and test snapshots to match new outputs.
Reviewed changes
Copilot reviewed 26 out of 30 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Bumps PHP to >=8.4 and updates Symfony + related package constraints to Symfony 8.1-era versions. |
| ecs.php | Adjusts ECS prepared set configuration (removes phpunit/strict prepared sets). |
| phpstan-baseline.neon | Regenerates/expands baseline to new PHPStan output format and updated rule results. |
| rector.php | Minor formatting cleanup (trailing whitespace removal). |
| src/Bundle/Platform/Kernel.php | Removes the custom configureContainer wrapper/alias usage and related imports. |
| src/Bundle/Platform/Model/User.php | Removes eraseCredentials() implementation. |
| src/Bundle/Platform/Form/Type/TextEditorType.php | Reorders helper method placement (no behavioral change). |
| src/Bundle/Platform/Form/DataTransformer/JsonDocumentTransformer.php | Reorders use const imports (style/consistency). |
| src/Bundle/Platform/Form/DataTransformer/SanitizeHtmlTransformer.php | Removes extra blank line (style). |
| src/Bundle/Saas/Config/SaasConfiguration.php | Import reordering. |
| src/Bundle/Saas/Console/Command/SubscriptionListCommand.php | Import reordering. |
| src/Bundle/Saas/DependencyInjection/SolidWorxPlatformSaasExtension.php | Import reordering. |
| src/Bundle/Saas/Feature/PlanFeatureManager.php | Import reordering. |
| src/Bundle/Saas/Feature/PlanFeatureToggle.php | Import reordering. |
| src/Bundle/Saas/Security/Voter/PlanFeatureVoter.php | Import reordering. |
| src/Bundle/Saas/Subscription/SubscriptionProviderInterface.php | Import reordering. |
| src/Tools/Rector/Rules/AddGenericMethodPhpDocRector.php | Import cleanup + formatting changes in CodeSample argument punctuation. |
| src/Tools/Rector/Rules/AddGenericTemplateExtendsRector.php | Import cleanup + formatting changes in CodeSample argument punctuation and minor style updates. |
| src/Tools/Rector/Rules/EnforcePlatformEntityRepositoryRector.php | Import reordering + formatting changes in CodeSample argument punctuation. |
| tests/Bundle/PlatformBundle/Feature/NoopFeatureGateTest.php | Anonymous class instantiation syntax adjusted (new class() form). |
| tests/Bundle/PlatformBundle/Form/Type/TextEditorTypeTest.php | Reformats arrays and moves getExtensions() override position. |
| tests/Bundle/Saas/Config/SaasConfigurationTest.php | Import reordering. |
| tests/Bundle/Saas/Feature/PlanFeatureGateTest.php | Docblock formatting + anonymous class instantiation syntax adjusted. |
| tests/Bundle/Saas/Feature/PlanFeatureManagerTest.php | Import reordering. |
| tests/Bundle/Saas/Security/Voter/PlanFeatureVoterTest.php | Import reordering. |
| tests/Bundle/Saas/Webhook/Converter/snapshots/LemonSqueezyPayloadConverterTest__testConvert with data set subscription created__1.yml | Snapshot normalization (links: {} formatting). |
| tests/Bundle/Saas/Webhook/Converter/snapshots/LemonSqueezyPayloadConverterTest__testConvert with data set subscription payment success__1.yml | Snapshot normalization (links: {} formatting). |
| tests/Bundle/Saas/Webhook/Converter/snapshots/LemonSqueezyPayloadConverterTest__testConvert with data set subscription updated__1.yml | Snapshot normalization (links: {} formatting). |
| tests/Bundle/Saas/Webhook/Converter/snapshots/LemonSqueezyPayloadConverterTest__testConvert with data set subscription updated on_trial__1.yml | Snapshot normalization (links: {} formatting). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+87
to
+88
| CODE_SAMPLE | ||
| , |
Comment on lines
+162
to
+163
| CODE_SAMPLE | ||
| , |
Coverage Report for CI Build 27780222704Warning No base build found for commit Coverage: 20.116%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.