Fix/coroutine errors#3015
Merged
Merged
Conversation
SamsungAudio refresh and notification handlers assumed UPnP responses always included UIC/response data. Some speakers intermittently return partial XML, so command.volume/getMute/getPlayStatus returned nil or attempted to index ret.handler_res.root.UIC, causing coroutine errors at init.lua:97/101 and command.lua:98. When this happened, refresh processing crashed and users saw stale volume/mute state updates, failed refresh cycles, and unreliable audio notification unmute behavior. This change adds nil-safe response extraction for key polling commands, logs when UIC payloads are missing, and hardens refresh/audio-notification handlers to skip emitting volume/mute events when state data is unavailable instead of crashing.
Matter lock state reports can include values not present in the legacy LOCK_STATE map. When that happens, lock_state_handler passed nil to device:emit_event, which crashes with attempt to index nil capability_event in st/device.lua and interrupts lock event processing for the device. Add a nil check before emit_event and fall back to capabilities.lock.lock.unknown() for unrecognized lock state values. This prevents coroutine failures while still surfacing a safe lock state to users. Also add an integration test that injects an unknown LockState value and verifies the driver emits lock.unknown instead of crashing.
Add zll poll time maintenance to avoid stale timers when devices are removed. Add nil check in poll callback
cjswedes
requested review from
NoahCornell,
aleclorimer,
hcarter-775 and
tpmanley
|
Channel deleted. |
|
matter-lock_coverage.xml
zigbee-switch_coverage.xml
zigbee-valve_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against a63f5fd |
NoahCornell
approved these changes
Jun 4, 2026
hcarter-775
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a set of coroutine errors I saw in our beta population with our increased observability into these errors.