Matter Ikea Scroll: Aggregate multiple responses into one event, add global bounds checking#3014
Open
hcarter-775 wants to merge 2 commits into
Open
Matter Ikea Scroll: Aggregate multiple responses into one event, add global bounds checking#3014hcarter-775 wants to merge 2 commits into
hcarter-775 wants to merge 2 commits into
Conversation
|
Invitation URL: |
Test Results 73 files 515 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 1fa21e3. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 1fa21e3 |
hcarter-775
force-pushed
the
add/multi-response-block-support
branch
from
336c8e1 to
0ca61eb
Compare
hcarter-775
force-pushed
the
add/multi-response-block-support
branch
from
0ca61eb to
1fa21e3
Compare
hcarter-775
requested review from
ctowns,
gharveymn,
nickolas-deboom and
tpmanley
tpmanley
reviewed
Jun 5, 2026
|
|
||
| function IkeaScrollEventUtils.requeue_clear_scroll_state(device) | ||
| -- Stores a timer object, which is required to cancel a timer early | ||
| local CLEAR_STATE_TIMER = "__clear_state_timer" |
Contributor
There was a problem hiding this comment.
I'd suggest putting this definition and the timeout (delay_s = 8) into fields along with the other fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add aggregation logic to ensure that only the last info block is handled when multiple responses come in to the driver at once, leaving all single-response chunks unaltered. This should aggregate all un-handled steps into before sending out the single event.
Add global bounds checking to ensure that if, in a single time-defined scroll series, no superfluous events are sent.
Summary of Completed Tests
Tested on various numbers of devices to ensure performant behavior across these varying cases.