Skip to content

Add option to use vanilla hunger bar sprites as mana bar#2471

Merged
AzureAaron merged 4 commits into
SkyblockerMod:mainfrom
AlphaNecron:main
Jul 1, 2026
Merged

Add option to use vanilla hunger bar sprites as mana bar#2471
AzureAaron merged 4 commits into
SkyblockerMod:mainfrom
AlphaNecron:main

Conversation

@AlphaNecron

Copy link
Copy Markdown
Contributor

Self-explanatory title :D
I'm using some cat packs and they all got cool hunger bar (fishes), which looks pretty decent as a mana bar, but Skyblocker is using a hardcoded set of textures which is really uncool...
(Ik we can just override Skyblocker-namespaced textures but that takes a lot of effort to recolor to a sensible color, and we gotta do that for every single resource pack)

A demo with the new bar

cropped.mp4

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Jun 17, 2026
@AlphaNecron

Copy link
Copy Markdown
Contributor Author

Not sure bout that OVERFLOW_DARK thingy, that requires tinting tho.

@AlphaNecron AlphaNecron changed the title Add option to use vanilla hunger bar textures as mana bar Add option to use vanilla hunger bar sprites as mana bar Jun 18, 2026
@AlphaNecron

Copy link
Copy Markdown
Contributor Author

Dunno if I should add an option to disable blinking as well, might be visually cleaner though.

@AzureAaron AzureAaron added this to the 6.6.0 milestone Jun 20, 2026
Comment thread src/main/java/de/hysky/skyblocker/skyblock/fancybars/VanillaStyleManaBar.java Outdated
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Jun 21, 2026
@AzureAaron AzureAaron requested a review from viciscat June 21, 2026 02:10
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Jun 21, 2026
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Jun 21, 2026
Comment thread src/main/java/de/hysky/skyblocker/mixins/accessors/GuiAccessor.java Outdated
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes reviews needed This PR needs reviews and removed reviews needed This PR needs reviews changes requested This PR need changes labels Jun 21, 2026
@AlphaNecron AlphaNecron requested a review from AzureAaron June 24, 2026 12:42
viciscat
viciscat previously approved these changes Jun 27, 2026

@viciscat viciscat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat

@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Jun 27, 2026
@AzureAaron

Copy link
Copy Markdown
Collaborator

This needs to be rebased, mainly just copy the GuiInvoker accessors to the 26.2 Hud accessor class.

@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Jun 29, 2026
@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jul 1, 2026
@AzureAaron AzureAaron merged commit beecc65 into SkyblockerMod:main Jul 1, 2026
3 checks passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Jul 1, 2026
Alex33856 pushed a commit that referenced this pull request Jul 1, 2026
* feat(ui): add option to use vanilla hunger bar textures as mana

* chore: use "sprite" term instead of "texture"

* feat(ui): add option to toggle vanilla mana bar blinking

* fix(res): use GuiAccessor to extract hunger bar sprites

(cherry picked from commit beecc65)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature This issue or PR is a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants