Skip to content

fix(frontend): restore sidebar resize button and functionality (#9370)#10872

Open
CodeOtaku-01 wants to merge 2 commits intoSigNoz:mainfrom
CodeOtaku-01:fix/sidebar-resize-button-9370
Open

fix(frontend): restore sidebar resize button and functionality (#9370)#10872
CodeOtaku-01 wants to merge 2 commits intoSigNoz:mainfrom
CodeOtaku-01:fix/sidebar-resize-button-9370

Conversation

@CodeOtaku-01
Copy link
Copy Markdown

@CodeOtaku-01 CodeOtaku-01 commented Apr 7, 2026

Description

This PR fixes issue #9370 where the sidebar resize (expand/collapse) button was missing from the UI and non-functional when the sidebar was closed.

Changes Made

  • SideNav Component: Restored the collapse-expand-handlers div and added handleTogglePinned prop.
  • AppLayout Integration: Passed the handleToggleSidebar function to SideNav so the button can trigger the state change.
  • Styling: Updated SideNav.styles.scss to make the button visible and added premium hover/interactive styles.
  • Icons: Used ChevronLeft and ChevronRight from lucide-react to clearly indicate the button's action.

Verification Results

  • Verified that the button is now visible at the bottom of the sidebar.
  • Confirmed that clicking the button successfully toggles the sidebar state between collapsed and expanded.
  • Fixed a syntax error in the component props that was causing TypeScript lint errors.

Fixes #9370


Note

Low Risk
Low risk UI change: adds a missing sidebar toggle control and styles; main risk is minor layout/CSS regressions or incorrect toggle state wiring.

Overview
Restores the sidebar collapse/expand button in SideNav and wires it to the existing toggle logic via a new handleTogglePinned prop passed from AppLayout.

Updates the collapse-expand-handlers styles to ensure the control is visible and adds hover/interaction styling, and uses ChevronLeft/ChevronRight icons to reflect the pinned state.

Reviewed by Cursor Bugbot for commit 2594363. Bugbot is set up for automated code reviews on this repo. Configure here.

@CodeOtaku-01 CodeOtaku-01 requested a review from a team as a code owner April 7, 2026 17:49
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2594363. Configure here.

Comment thread frontend/src/container/SideNav/SideNav.styles.scss
@H4ad
Copy link
Copy Markdown
Contributor

H4ad commented Apr 8, 2026

Thanks for the PR, can you please add a video about the fix before and after the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resize button does not work when sidebar is closed; expanding should open the sidebar

3 participants