fix(frontend): restore sidebar resize button and functionality (#9370)#10872
Open
CodeOtaku-01 wants to merge 2 commits intoSigNoz:mainfrom
Open
fix(frontend): restore sidebar resize button and functionality (#9370)#10872CodeOtaku-01 wants to merge 2 commits intoSigNoz:mainfrom
CodeOtaku-01 wants to merge 2 commits intoSigNoz:mainfrom
Conversation
|
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2594363. Configure here.
Contributor
|
Thanks for the PR, can you please add a video about the fix before and after the change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR fixes issue #9370 where the sidebar resize (expand/collapse) button was missing from the UI and non-functional when the sidebar was closed.
Changes Made
collapse-expand-handlersdiv and addedhandleTogglePinnedprop.handleToggleSidebarfunction toSideNavso the button can trigger the state change.SideNav.styles.scssto make the button visible and added premium hover/interactive styles.ChevronLeftandChevronRightfromlucide-reactto clearly indicate the button's action.Verification Results
Fixes #9370
Note
Low Risk
Low risk UI change: adds a missing sidebar toggle control and styles; main risk is minor layout/CSS regressions or incorrect toggle state wiring.
Overview
Restores the sidebar collapse/expand button in
SideNavand wires it to the existing toggle logic via a newhandleTogglePinnedprop passed fromAppLayout.Updates the
collapse-expand-handlersstyles to ensure the control is visible and adds hover/interaction styling, and usesChevronLeft/ChevronRighticons to reflect the pinned state.Reviewed by Cursor Bugbot for commit 2594363. Bugbot is set up for automated code reviews on this repo. Configure here.