fix: added default order by for list queries#10870
Open
tushar-signoz wants to merge 1 commit intomainfrom
Open
fix: added default order by for list queries#10870tushar-signoz wants to merge 1 commit intomainfrom
tushar-signoz wants to merge 1 commit intomainfrom
Conversation
Member
|
@tushar-signoz please fix the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ORDER BY timestamp DESCfor list/raw queries (logs, traces) in theQueryRangeAPI handler when no explicit order is specifiedWhat changed
In
pkg/querier/api.go, theQueryRangehandler now callsqueryRangeRequest.UseDefaultOrderBy()before executing the query. This method (already defined inquerybuildertypesv5) applies a timestamp-descending default order to raw/list/trace request types when no order-by clause is present.Test plan
🤖 Generated with Claude Code