Skip to content

chore: asset management and migration#10846

Closed
SagarRajput-7 wants to merge 8 commits intomainfrom
asset-migration
Closed

chore: asset management and migration#10846
SagarRajput-7 wants to merge 8 commits intomainfrom
asset-migration

Conversation

@SagarRajput-7
Copy link
Copy Markdown
Contributor

@SagarRajput-7 SagarRajput-7 commented Apr 6, 2026

Pull Request


📄 Summary

Why does this change exist?
What problem does it solve, and why is this the right approach?

Screenshots / Screen Recordings (if applicable)

Include screenshots or screen recordings that clearly show the behavior before the change and the result after the change. This helps reviewers quickly understand the impact and verify the update.

Issues closed by this PR

Reference issues using Closes #issue-number to enable automatic closure on merge.

closes - (task) asset management in signoz according to Vite


✅ Change Type

Select all that apply

  • ✨ Feature
  • 🐛 Bug fix
  • ♻️ Refactor
  • 🛠️ Infra / Tooling
  • 🧪 Test-only

🐛 Bug Context

Required if this PR fixes a bug

Root Cause

What caused the issue?
Regression, faulty assumption, edge case, refactor, etc.

Fix Strategy

How does this PR address the root cause?


🧪 Testing Strategy

How was this change validated?

  • Tests added/updated:
  • Manual verification:
  • Edge cases covered:

⚠️ Risk & Impact Assessment

What could break? How do we recover?

  • Blast radius:
  • Potential regressions:
  • Rollback plan:

📝 Changelog

Fill only if this affects users, APIs, UI, or documented behavior
Use N/A for internal or non-user-facing changes

Field Value
Deployment Type Cloud / OSS / Enterprise
Change Type Feature / Bug Fix / Maintenance
Description User-facing summary

📋 Checklist

  • Tests added or explicitly not required
  • Manually tested
  • Breaking changes documented
  • Backward compatibility considered

👀 Notes for Reviewers


@SagarRajput-7 SagarRajput-7 changed the title Asset migration feat: asset management and migration Apr 6, 2026
@github-actions github-actions Bot added docs required enhancement New feature or request labels Apr 6, 2026
@SagarRajput-7 SagarRajput-7 changed the title feat: asset management and migration chore: asset management and migration Apr 6, 2026
@github-actions github-actions Bot added the chore label Apr 8, 2026
Move public/Icons, public/Images, public/Logos, public/svgs to
src/assets/ and replace all string literal asset references across
74 files with ES imports via the @ alias.

Assets are now processed through Vite's module pipeline, making them
content-hashed in dist/ and base-path-aware — prerequisite for the
runtime URL prefix feature (base path).

Known gap: src/ReactI18/index.tsx loadPath still uses absolute /locales/
path — to be fixed in the base path feature PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant