Skip to content

fix: show warning for non-existent cost meter metrics#10843

Open
namanv3 wants to merge 8 commits intomainfrom
nv/4325
Open

fix: show warning for non-existent cost meter metrics#10843
namanv3 wants to merge 8 commits intomainfrom
nv/4325

Conversation

@namanv3
Copy link
Copy Markdown
Contributor

@namanv3 namanv3 commented Apr 6, 2026

Pull Request


If an organisation hasn't set up cost meters, then the costs page currently throws errors for them. Given that these are internal metrics, we should not do this. We should just give a warning.

Screenshots / Screen Recordings (if applicable)

Screenshot 2026-04-05 at 22 32 40 Screenshot 2026-04-05 at 22 35 16

Issues closed by this PR

Closes https://github.com/SigNoz/engineering-pod/issues/4325


✅ Change Type

Select all that apply

  • ✨ Feature
  • 🐛 Bug fix
  • ♻️ Refactor
  • 🛠️ Infra / Tooling
  • 🧪 Test-only

🐛 Bug Context

What the meters page looked like before #10560

Screenshot 2026-04-06 at 10 31 19

🧪 Testing Strategy

How was this change validated?

  • Tests added/updated: Integration tests
  • Manual verification: Done, screenshots added
  • Edge cases covered: Yes

📝 Changelog

Fill only if this affects users, APIs, UI, or documented behavior
Use N/A for internal or non-user-facing changes

Field Value
Deployment Type Cloud / OSS / Enterprise
Change Type Bug Fix
Description If cost meters have not been set, the page does not throw errors anymore

📋 Checklist

  • Tests added or explicitly not required
  • Manually tested
  • Breaking changes documented
  • Backward compatibility considered

@github-actions github-actions Bot added the bug Something isn't working label Apr 6, 2026
@namanv3 namanv3 marked this pull request as ready for review April 6, 2026 05:04
@namanv3 namanv3 added the safe-to-integrate Run integration tests label Apr 6, 2026
@namanv3 namanv3 added safe-to-integrate Run integration tests and removed safe-to-integrate Run integration tests labels Apr 6, 2026
@namanv3 namanv3 added safe-to-integrate Run integration tests and removed safe-to-integrate Run integration tests labels Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working safe-to-integrate Run integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant