Skip to content

refactor(icons): replace LoadingOutlined with SigNoz Loader#10839

Open
yadavshubham01 wants to merge 8 commits intoSigNoz:mainfrom
yadavshubham01:feat/replace-loading-icon
Open

refactor(icons): replace LoadingOutlined with SigNoz Loader#10839
yadavshubham01 wants to merge 8 commits intoSigNoz:mainfrom
yadavshubham01:feat/replace-loading-icon

Conversation

@yadavshubham01
Copy link
Copy Markdown

@yadavshubham01 yadavshubham01 commented Apr 5, 2026

Pull Request


📄 Summary

This PR addresses issue #10346.

Replaced the LoadingOutlined ant-icon with SigNoz Loader / LoaderCircle icons
Updated high-frequency usage areas incrementally (starting with this PR)
Ensured consistency with the current design system and icon standards

This is part of a series of PRs where high-frequency icons are being updated step-by-step to avoid large changes in a single PR.

Changes Made

Replaced LoadingOutlined → Loader / LoaderCircle
Updated relevant components without altering functionality

Screenshots / Screen Recordings (if applicable)

Screen.Recording.2026-04-06.110901.mp4

Issues closed by this PR

Related #10346


✅ Change Type

Select all that apply

  • ✨ Feature
  • 🐛 Bug fix
  • ♻️ Refactor
  • 🛠️ Infra / Tooling
  • 🧪 Test-only

🧪 Testing Strategy

How was this change validated?

  • Tests added/updated: -
  • Manual verification: Yes
  • Edge cases covered: -

⚠️ Risk & Impact Assessment

What could break? How do we recover?

  • Blast radius: Icons
  • Potential regressions: Icon Loader being rendered wrong
  • Rollback plan: Revert this commit

📝 Changelog

Fill only if this affects users, APIs, UI, or documented behavior
Use N/A for internal or non-user-facing changes

Field Value
Deployment Type Cloud / OSS / Enterprise
Change Type Maintenance
Description Updated all icons of loading to our own version from our library.

📋 Checklist

  • Tests added or explicitly not required
  • Manually tested
  • Breaking changes documented
  • Backward compatibility considered

Note

Low Risk
Low risk visual-only change: replaces loading indicators across many UI surfaces without altering data flow or business logic. Main regression risk is minor styling/alignment differences or incorrect icon import in a few components.

Overview
Replaces Ant Design’s LoadingOutlined spinner icon with SigNoz loader icons (@signozhq/icons Loader/LoaderCircle) across multiple high-traffic UI loading states (tables, modals, selects, dashboards, onboarding, and misc. status indicators).

This updates the shared Spinner component and numerous Spin/button icon usages to render the new loader with animate-spin, aiming for consistent iconography while keeping behavior unchanged.

Reviewed by Cursor Bugbot for commit 444f01f. Bugbot is set up for automated code reviews on this repo. Configure here.

@yadavshubham01 yadavshubham01 requested review from a team as code owners April 5, 2026 18:12
@welcome
Copy link
Copy Markdown

welcome Bot commented Apr 5, 2026

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 444f01f. Configure here.

Comment thread frontend/src/container/InfraMonitoringK8s/StatefulSets/K8sStatefulSetsList.tsx Outdated
Comment thread frontend/src/container/PipelinePage/Layouts/ChangeHistory/utils.tsx Outdated
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 6, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@yadavshubham01
Copy link
Copy Markdown
Author

@YounixM need review

@yadavshubham01
Copy link
Copy Markdown
Author

@H4ad @YounixM need review

@H4ad H4ad changed the title Feat: replace LoadingOutlined with SigNoz Loader icons refactor(icons): replace LoadingOutlined with SigNoz Loader Apr 8, 2026
@H4ad H4ad added frontend refactored safe-to-test Run CI tests for dependabot and external contributors labels Apr 8, 2026
Copy link
Copy Markdown
Contributor

@H4ad H4ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, would you mind taking a look at the failling tests and format/lint issues?

@yadavshubham01
Copy link
Copy Markdown
Author

Thanks for the PR, would you mind taking a look at the failling tests and format/lint issues?

Sure

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 8, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@primus-bot primus-bot Bot removed the safe-to-test Run CI tests for dependabot and external contributors label Apr 8, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 8, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 8, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 8, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@yadavshubham01 yadavshubham01 requested a review from H4ad April 8, 2026 16:34
@H4ad H4ad added the safe-to-test Run CI tests for dependabot and external contributors label Apr 8, 2026
@H4ad
Copy link
Copy Markdown
Contributor

H4ad commented Apr 17, 2026

@yadavshubham01 Only one issue in the lint, and then we will be good to merge

@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 17, 2026

You have used all of your free Bugbot PR reviews.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@primus-bot primus-bot Bot removed the safe-to-test Run CI tests for dependabot and external contributors label Apr 17, 2026
@yadavshubham01
Copy link
Copy Markdown
Author

@H4ad done

@H4ad H4ad added the safe-to-test Run CI tests for dependabot and external contributors label Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend refactored safe-to-test Run CI tests for dependabot and external contributors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants