Don't send user vite parsing errors to observe#3653
Draft
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
lucyxiang
force-pushed
the
04-01-rethrowasusererror_for_knows_user_code_errors
branch
from
713995b to
a109836
Compare
lucyxiang
changed the title
lucyxiang
force-pushed
the
04-01-rethrowasusererror_for_knows_user_code_errors
branch
from
a109836 to
79b6d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Don't send user Vite parse error to observe (caused by invalid syntax or wrong file extension in a specific merchant project)
Fixes https://vault.shopify.io/teams/13725-Developer-Platforms/issues/22640-error-31m-vite-build-import-analysis-plugin-vite-build-import-analysis-app-lib-admin-auth-js-62-3-failed-to-parse-source-for-import-analysis-because-the-content-contains-invalid-js-syntax-if-you-are-using-jsx-make-sure-to-name-the-file
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist