Fix AppImage OpenSSL runtime#421
Open
bedlaj wants to merge 1 commit intoSevenTV:chatterino7from
Open
Conversation
Collaborator
|
Thank you for looking into this. I saw other projects that use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #420
The AppImage bundles
libssl.so.3andlibcrypto.so.3, but it did not bundle matching OpenSSL 3 runtime files.On Fedora this breaks websocket TLS handshakes with:
unregistered scheme (STORE routines)This was visible mostly as Kick chat not receiving messages, because Kick chat uses the Pusher websocket. Kick login and stream preview still worked. Twitch basic chat could also still work, because that path does not depend on the same websocket.
Result binaries can be reviewed on my fork nightly release https://github.com/bedlaj/chatterino7/releases/tag/nightly-build
I have tested only Fedora 43, I have no acces to windows or other linux dists.
Code was AI assisted (codex)