7TV paints when mentioned#413
Open
BennyyyBB wants to merge 2 commits intoSevenTV:chatterino7from
Open
Conversation
Collaborator
|
Thank you for the PR! I'd rather have paints respect the |
Author
|
@Nerixyz Yes, that's what I'm thinking as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed Changes
This is a possible adjustment for issue #404 that hopefully adds an option to disable 7TV paints when a user is mentioned in chat.
Furthermore, I tried to implement a feature with the new option, "Enable paints on @usernames," by creating an additional checkbox in the settings that hopefully allows separate control over the display of 7TV paints for mentions (see commit f215ab4). I tried to achieved this by implementing a check in the rendering logic of the MessageLayoutElement.cpp file that distinguishes between the actual sender of a message and a mere mention within the text. If that new option is disabled or the general coloring of mentions is turned off, the system should specifically suppress the drawing of paints for these mentions. This ensures that the paints respect existing user settings and that mentions are displayed simply and without color effects when necessary.
Types of Changes
Checklist
more Notes
Since this is only a draft/prototype to implement this new feature, there might be some more adjustments to be added. I'm happy to work on it if you have improvements or more suggestions.