[WIP] Update Minimax M3 B300 FP4 vllm#1994
Conversation
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. 感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致 如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow 一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。 如需更多帮助,PR 作者可通过 Slack 联系核心维护者。 |
2 similar comments
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. 感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致 如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow 一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。 如需更多帮助,PR 作者可通过 Slack 联系核心维护者。 |
|
Thanks for the contribution! For vLLM & SGLang, please ensure that your recipes is similar to the official vLLM recipes and/or the SGLang cookbook If it is not, please create a PR first before we can merge your single node PR into the master branch. Let's ensure that the documentation is first class such that the entire ML community can benefit from your hard work! Thank you PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. If re-running failed jobs is attempted, PR authors are responsible for ensuring it passes. See GitHub's docs on re-running failed jobs: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow As a rule of thumb, generally, PR authors should request a review & get a PR approval from the respective companies' CODEOWNERS before requesting a review from core maintainers. If additional help is needed, PR authors can reach out to core maintainers over Slack. 感谢你的贡献!对于 vLLM 与 SGLang,请确保你的 recipe 与官方 vLLM recipes 和/或 SGLang cookbook 保持一致 如果不一致,请先创建一个 PR,之后我们才能将你的单节点 PR 合并到 master 分支。让我们确保文档保持一流水准,使整个 ML 社区都能从你的辛勤工作中受益!谢谢 PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。如果选择重新运行失败的任务,PR 作者有责任确保其最终通过。参见 GitHub 关于重新运行失败任务的文档:https://docs.github.com/en/actions/how-tos/manage-workflow-runs/re-run-workflows-and-jobs#re-running-failed-jobs-in-a-workflow 一般而言,PR 作者应先向相应公司的 CODEOWNERS 请求审阅并获得 PR 批准,然后再请求核心维护者审阅。 如需更多帮助,PR 作者可通过 Slack 联系核心维护者。 |
| description: | ||
| - "Update Minimax M3 b300 vllm image tag" | ||
| - "Update search space to cover more configs" | ||
| pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/ No newline at end of file |
There was a problem hiding this comment.
🔴 The new perf-changelog entry at line 4435 has pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/ with no PR number appended (should be 1994), and the file no longer ends with a trailing newline. The missing newline will cause utils/validate_perf_changelog.py to raise ChangelogValidationError and fail the CI Validate perf-changelog matrix step. Fix both: append 1994 to the URL and add a trailing newline.
Extended reasoning...
What's wrong\n\nThe last entry added to perf-changelog.yaml has two issues on the same line (4435):\n\n1. pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/ — the PR number is missing. Every other entry in the file uses the fully-qualified .../pull/<N> form (see line 4409 → 1923, line 4420 → 1962, line 4428 → 1975). This PR is #1994, so the value should be https://github.com/SemiAnalysisAI/InferenceX/pull/1994.\n2. The diff footer shows \\ No newline at end of file; the file no longer terminates with \\n.\n\nWhy the missing newline actually breaks CI (not just style)\n\nutils/validate_perf_changelog.py has an explicit check in parse_changelog():\n\npython\nif not raw.endswith(b"\\n"):\n raise ChangelogValidationError(f"{label} does not end with a newline")\n\n\nThis validator is invoked by CI in .github/workflows/run-sguweep.yml as python3 utils/validate_perf_changelog.py. So on push the Validate perf-changelog matrix step will fail before the sweep even starts. AGENTS.md line 150 reinforces this: "Never delete or modify whitespace in perf-changelog.yaml — CI depends on exact whitespace ... Altering it breaks CI."\n\nImpact\n\nMerge is blocked until fixed. Even setting CI aside, the broken pr-link URL renders as a 404 in any downstream tooling that consumes the changelog to link back to the PR.\n\nStep-by-step proof (missing newline)\n\n1. Apply this PR to a checkout: the diff ends pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/ followed by \\ No newline at end of file.\n2. Run python3 utils/validate_perf_changelog.py locally.\n3. parse_changelog reads the file into raw, checks raw.endswith(b"\\n"), sees it is False, and raises ChangelogValidationError("perf-changelog.yaml does not end with a newline").\n4. In CI this fails the validate step and blocks the full-sweep-enabled workflow.\n\nFix\n\nOn the last line append 1994 and a trailing newline, so the entry becomes:\n\nyaml\n pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/1994\n\n\nwith a terminating \\n. Both are one-character changes and should ship together since they are on the same line.
|
see unofficial run visualizer at https://inferencex.semianalysis.com/inference?unofficialRun=28624280386 |
No description provided.