qt-creator(-cdb-ext)-git: Add version 19.0.1#2842
qt-creator(-cdb-ext)-git: Add version 19.0.1#2842e-gleba wants to merge 4 commits intoScoopInstaller:masterfrom
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdded three Scoop package manifests for Qt Creator version 19.0.1: the main Qt Creator application, a CDB debugger extension, and a wininterrupt component. Each manifest specifies download URLs, SHA256 hashes, dependencies, post-install hooks, and automatic update configuration for Windows. ChangesQt Creator Package Ecosystem
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 45 minutes and 21 seconds.Comment |
z-Fng
changed the title
- Add `conflicts_with` to prevent side-by-side installation with official `extras/qt-creator` and `extras/qt-creator-cdb-ext` packages - Improve `notes` to explicitly mention x64-only limitation (GitHub releases do not provide arm64 builds, unlike official Qt mirrors) - Replace placeholder fake MD5 hashes with `TODO` markers to signal that real hashes must be computed before merge - Keep `checkver`/`autoupdate` structure aligned with Scoop conventions - No functional URL or dependency changes
- Remove `conflicts_with` — this field does not exist in Scoop schema (schema.json has no such property; conflict warnings moved to `notes`) - Remove invalid `"hash": "TODO"` — does not match hashPattern regex (schema requires md5:32hex, sha256:64hex, etc.) - Omit `hash` entirely for now — schema-valid, install will warn (real hashes must be computed from release assets before merge) - Expand `notes` to explicitly warn about side-by-side install conflict with official `extras/qt-creator` and `extras/qt-creator-cdb-ext` - All other fields remain unchanged and schema-valid
- Add verified SHA256 hashes from GitHub release API digest field:
- qtcreator-windows-x64-msvc-19.0.1.7z:
d6bc6068587297ce2dc38787bc5ace43368f85ea59520117d2a702d59bd6e40f
- qtcreatorcdbext-windows-x64-msvc-19.0.1.7z:
cc042c1e5569c1ee5637dab034d02a8309b13214d6b32bcfc8655459d97f528a
- wininterrupt-windows-x64-msvc-19.0.1.7z:
d4c843d7a3daa1c203ed77c5797fe90251e5b1e8cc2a5a8409840d55e34faba9
- Add qt-creator-wininterrupt-git.json for full parity with Extras bucket trio
- All manifests schema-valid, conflict warnings in notes, x64-only documented
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/qt-creator-cdb-ext-git.json`:
- Line 20: The Remove-Item invocation that deletes qtcreatorcdbext* can emit a
non-terminating error on first install when the glob matches nothing; update the
command string in bucket/qt-creator-cdb-ext-git.json (the line containing
Remove-Item "$(appdir qt-creator-git $global)\\current\\lib\\qtcreatorcdbext*")
to add the PowerShell flag -ErrorAction SilentlyContinue (keeping -Force
-Recurse) so the command suppresses the spurious error when no items exist.
- Around line 19-22: Add a pre_uninstall step to remove the junctions created by
post_install so they don't become dangling when this package is removed: create
a "pre_uninstall" array that runs the same Remove-Item command used in
post_install (the Remove-Item targeting "$(appdir qt-creator-git
$global)\\current\\lib\\qtcreatorcdbext*" ) so junctions are deleted before the
versioned $dir is removed; ensure the new pre_uninstall entry mirrors the
cleanup logic currently in post_install.
In `@bucket/qt-creator-wininterrupt-git.json`:
- Line 19: The package creates hard links in qt-creator-git via the post_install
command which leaves orphaned executables on uninstall; add a pre_uninstall
entry that finds the same names (the "(Get-Item
$dir\\bin\\win*interrupt.exe).Name" pattern) and removes matching files from
"$(appdir qt-creator-git $global)\\current\\bin\\" (use Remove-Item with
-Force/-ErrorAction to quietly delete each matching hard link), ensuring you
mirror the same name-selection logic used in post_install so the exact linked
filenames are removed before uninstalling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8fb43f26-1ce2-409f-9ff0-b49cd014abdb
📒 Files selected for processing (3)
bucket/qt-creator-cdb-ext-git.jsonbucket/qt-creator-git.jsonbucket/qt-creator-wininterrupt-git.json
| "post_install": [ | ||
| "Remove-Item \"$(appdir qt-creator-git $global)\\current\\lib\\qtcreatorcdbext*\" -Force -Recurse", | ||
| "(Get-Item $dir\\lib\\qtcreatorcdbext*).Name | foreach { New-Item \"$(appdir qt-creator-git $global)\\current\\lib\\$_\" -ItemType Junction -Target \"$dir\\lib\\$_\" -Force | Out-Null }" | ||
| ], |
There was a problem hiding this comment.
Missing pre_uninstall — junctions become dangling on uninstall.
The post_install creates directory junctions inside qt-creator-git's current\lib\ that point to versioned paths under qt-creator-cdb-ext-git's own app directory (i.e., the $dir at install time). When qt-creator-cdb-ext-git is uninstalled, Scoop deletes that versioned directory, leaving the junctions in qt-creator-git's lib tree pointing at a non-existent target. The CDB debugger extension then silently breaks for the user until they manually clean up the orphaned junctions.
Add a pre_uninstall entry that mirrors the cleanup in step 1 of post_install:
🛠️ Proposed fix — add `pre_uninstall`
"depends": "versions/qt-creator-git",
+ "pre_uninstall": "Remove-Item \"$(appdir qt-creator-git $global)\\current\\lib\\qtcreatorcdbext*\" -Force -Recurse -ErrorAction SilentlyContinue",
"architecture": {🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/qt-creator-cdb-ext-git.json` around lines 19 - 22, Add a pre_uninstall
step to remove the junctions created by post_install so they don't become
dangling when this package is removed: create a "pre_uninstall" array that runs
the same Remove-Item command used in post_install (the Remove-Item targeting
"$(appdir qt-creator-git $global)\\current\\lib\\qtcreatorcdbext*" ) so
junctions are deleted before the versioned $dir is removed; ensure the new
pre_uninstall entry mirrors the cleanup logic currently in post_install.
1 participant
This PR adds
qt-creator-git,qt-creator-cdb-ext-git, andqt-creator-wininterrupt-gitmanifests to the Versions bucket, as discussed in ScoopInstaller/Extras#17716.These manifests download Qt Creator from the official Qt Creator GitHub releases instead of the Qt official mirrors (
download.qt.io), which are often slow or unreliable for users in certain regions.Key points:
qt-creatormanifest untouched in Extras bucketnotesfield warning that these are not officially supported builds per the GitHub release disclaimerqt-creator-cdb-ext-gitandqt-creator-wininterrupt-gitdepend onversions/qt-creator-gitqt-creator,qt-creator-cdb-ext,qt-creator-wininterrupt)Verified SHA256 hashes (from GitHub release API
digestfield):qtcreator-windows-x64-msvc-19.0.1.7z:d6bc6068587297ce2dc38787bc5ace43368f85ea59520117d2a702d59bd6e40fqtcreatorcdbext-windows-x64-msvc-19.0.1.7z:cc042c1e5569c1ee5637dab034d02a8309b13214d6b32bcfc8655459d97f528awininterrupt-windows-x64-msvc-19.0.1.7z:d4c843d7a3daa1c203ed77c5797fe90251e5b1e8cc2a5a8409840d55e34faba9Closes the discussion in Extras#17716 about providing an alternative download source.
Summary by CodeRabbit