Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 51 minutes and 19 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
WalkthroughThe PR refactors post-install scripts across all PHP Xdebug packages (versions 5.4–8.3) to dynamically detect installed PHP variants and gracefully handle missing PHP installations. Instead of failing with path-not-found errors, scripts now check if PHP exists, create directories as needed, and provide fallback instructions for manual configuration. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All changes look good. Wait for review from human collaborators. php54-xdebug
php55-xdebug
php56-xdebug
php70-xdebug
php71-xdebug
php72-xdebug
php73-xdebug
php74-xdebug
php80-xdebug
php81-xdebug
php82-xdebug
php83-xdebug
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/php54-xdebug.json`:
- Around line 32-45: The loop that checks installed PHP copies treats only the
case where xdebug.ini is created as handled, so when an existing xdebug.ini is
present $configUpdated stays $false and fallback instructions appear; update the
foreach block (the loop using installed, $phpGlobal, $configPath, Test-Path,
ensure, Add-Content and break) so that if Test-Path -Path $configPath returns
true you set $configUpdated = $true (and optionally log a message like
"xdebug.ini already present") and break, otherwise continue with the existing
creation path (ensure + Add-Content) and set $configUpdated = $true there as
before.
In `@bucket/php55-xdebug.json`:
- Around line 32-45: The script treats only creation of xdebug.ini as handled
because $configUpdated is only set when Add-Content runs; modify the foreach
block in which you check Test-Path for $configPath (inside the installed $php
$phpGlobal branch): when Test-Path returns true, set $configUpdated = $true (and
optionally Write-Host that the existing config is detected) before breaking out,
and keep the existing behavior of creating the file when Test-Path is false;
this ensures an existing xdebug.ini is considered handled and prevents falling
through to the manual-enable fallback.
In `@bucket/php70-xdebug.json`:
- Around line 32-45: The script treats only creating xdebug.ini as "handled" so
when PHP is installed but the xdebug.ini already exists $configUpdated remains
$false and the manual-enable warning is still shown; inside the foreach block
where you compute $configPath (the installed $php $phpGlobal branch) check
Test-Path -Path $configPath and if it exists set $configUpdated = $true (and
then break), otherwise perform the existing creation steps — this ensures an
existing xdebug.ini is considered handled and prevents the false warning.
In `@bucket/php71-xdebug.json`:
- Around line 32-45: The loop that checks installed PHP versions (the foreach
over $phpGlobal and the installed $php check) currently breaks when it finds PHP
7.1 installed but an existing xdebug.ini at $configPath, leaving $configUpdated
false and causing the fallback message to show; update the logic so that when
Test-Path -Path $configPath returns true you explicitly set $configUpdated =
$true (treating the existing xdebug.ini as a handled state) before breaking out
of the loop so the manual-enable message is not printed incorrectly.
In `@bucket/php72-xdebug.json`:
- Around line 24-30: The generated INI lines for Xdebug are using Xdebug 2
settings; update the $config array entries that currently include
"xdebug.remote_enable=on", "xdebug.remote_autostart=on", and
"xdebug.remote_connect_back=on" to the Xdebug 3 equivalents: replace with
"xdebug.mode=debug", "xdebug.start_with_request=yes", and
"xdebug.discover_client_host=true", and also add "xdebug.client_port=9003"
alongside the existing zend_extension/php_xdebug.dll and "[xdebug]" lines so the
produced INI enables Xdebug 3 debugging correctly.
In `@bucket/php73-xdebug.json`:
- Around line 24-30: The INI lines built into the $config array use Xdebug 2
keys but the package is Xdebug 3; update the entries inside $config (replace
"xdebug.remote_enable=on" with "xdebug.mode=debug", replace
"xdebug.remote_autostart=on" with "xdebug.start_with_request=yes" or "trigger",
replace "xdebug.remote_connect_back=on" with "xdebug.discover_client_host=true")
and add a new line "xdebug.client_port=9003" so the generated INI uses Xdebug 3
settings.
In `@bucket/php74-xdebug.json`:
- Around line 24-30: The Xdebug INI generation uses old Xdebug 2 keys in the
$config block (zend_extension=php_xdebug.dll and the three remote_* settings);
update that $config array to Xdebug 3 keys: replace "xdebug.remote_enable=on"
with "xdebug.mode=develop,debug", replace "xdebug.remote_autostart=on" with
"xdebug.start_with_request=yes" (or "trigger" if preferred), replace
"xdebug.remote_connect_back=on" with "xdebug.discover_client_host=true", and add
"xdebug.client_port=9003"; keep the zend_extension line as-is and ensure all new
keys are included in the same $config string join used to write the INI.
In `@bucket/php81-xdebug.json`:
- Around line 28-41: The script currently leaves $configUpdated as $false when
PHP is installed but xdebug.ini already exists, causing false "manual-enable"
instructions; inside the foreach that checks installed $php $phpGlobal (the
block using $configPath, Test-Path, ensure, Add-Content and break), set
$configUpdated = $true as soon as you detect the PHP installation (either before
the Test-Path check or in an else branch when Test-Path returns true) so
existing xdebug.ini is treated as handled, and apply the same change to the
identical block in the other php*-xdebug.json manifests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6d9b07b4-c2a7-462f-8e28-f62e2199525e
📒 Files selected for processing (12)
bucket/php54-xdebug.jsonbucket/php55-xdebug.jsonbucket/php56-xdebug.jsonbucket/php70-xdebug.jsonbucket/php71-xdebug.jsonbucket/php72-xdebug.jsonbucket/php73-xdebug.jsonbucket/php74-xdebug.jsonbucket/php80-xdebug.jsonbucket/php81-xdebug.jsonbucket/php82-xdebug.jsonbucket/php83-xdebug.json
Member
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. php54-xdebug
php55-xdebug
php56-xdebug
php70-xdebug
php71-xdebug
php72-xdebug
php73-xdebug
php74-xdebug
php80-xdebug
php81-xdebug
php82-xdebug
php83-xdebug
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Release Notes
Bug Fixes
Chores