Skip to content

ghidra92: Add version 9.2#2805

Merged
z-Fng merged 1 commit intomasterfrom
add-ghidra92
Apr 14, 2026
Merged

ghidra92: Add version 9.2#2805
z-Fng merged 1 commit intomasterfrom
add-ghidra92

Conversation

@z-Fng
Copy link
Copy Markdown
Member

@z-Fng z-Fng commented Apr 14, 2026

Closes #2304

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

New Features

  • Ghidra version 9.2 is now available for installation with automatic configuration and environment setup.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 14, 2026

Walkthrough

A new manifest file for Ghidra version 9.2 has been added to the bucket. The manifest specifies package metadata, download source with hash verification, extraction settings, JDK dependency suggestion, install-time environment configuration, and a post-install script to manage configuration file persistence.

Changes

Cohort / File(s) Summary
Ghidra 9.2 Manifest
bucket/ghidra92.json
New package manifest for Ghidra 9.2 with metadata, 64-bit download link, SHA-256 hash, extraction directory, environment variable setup, post-install configuration directory migration script, executable registration, shortcut definition, and persistence configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 A manifest hops into the bucket, pristine and new,
Ghidra 9.2 now joins the crew!
With configurations to persist and paths to define,
The reverse engineer's toolkit continues to shine! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: adding Ghidra version 9.2 with a new manifest file.
Description check ✅ Passed The PR description references the closed issue and confirms both checklist items (conventional title format and reading the Contributing Guide).
Linked Issues check ✅ Passed The PR successfully implements all coding requirements from issue #2304: provides Ghidra 9.2 manifest with correct metadata, download URL pointing to the GitHub release, and appropriate post-install script.
Out of Scope Changes check ✅ Passed All changes are scoped to issue #2304: a single new manifest file for Ghidra 9.2 with no unrelated modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch add-ghidra92

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

ghidra92

  • Lint
  • Description
  • License
  • Hashes

Check the full log for details.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/ghidra92.json`:
- Line 4: Update the manifest's homepage field to match the issue objective by
replacing the current "homepage" value (the "homepage" entry in ghidra92.json)
from "https://github.com/NationalSecurityAgency/ghidra" to
"https://ghidra-sre.org/" so the manifest consistently uses the requested site.
- Around line 17-23: The post_install PowerShell snippet uses Copy-Item and
Remove-Item on "Configurations.original" without ensuring the destination exists
or verifying the copy succeeded; update the post_install logic so it first
checks Test-Path for "$dir\\Ghidra\\Configurations.original", ensures the target
"$persist_dir\\Ghidra\\Configurations" exists (e.g., New-Item -ItemType
Directory -Force or equivalent), perform the copy with error propagation (e.g.,
-ErrorAction Stop or a try/catch), and only call Remove-Item on
"$dir\\Ghidra\\Configurations.original" if the copy completed successfully;
reference the existing Copy-Item and Remove-Item lines and the $dir/$persist_dir
variables when making these changes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c3bdeb4a-4e74-4de7-80bd-5bf69e7650be

📥 Commits

Reviewing files that changed from the base of the PR and between 11cddd1 and 18c5a36.

📒 Files selected for processing (1)
  • bucket/ghidra92.json

Comment thread bucket/ghidra92.json
Comment thread bucket/ghidra92.json
@z-Fng z-Fng merged commit 04074b3 into master Apr 14, 2026
6 checks passed
@z-Fng z-Fng deleted the add-ghidra92 branch April 14, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: Ghidra 9.2

1 participant