Skip to content

(chore): Clean up redundant try-catch blocks in checkver#2794

Merged
z-Fng merged 1 commit intomasterfrom
fix-checkver
Apr 7, 2026
Merged

(chore): Clean up redundant try-catch blocks in checkver#2794
z-Fng merged 1 commit intomasterfrom
fix-checkver

Conversation

@z-Fng
Copy link
Copy Markdown
Member

@z-Fng z-Fng commented Apr 7, 2026

Benefit from:

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

Release Notes

  • Chores
    • Improved version checking and update detection mechanisms for multiple nightly and development builds (goneovim, ipfilter, lapce, orcaslicer, prismlauncher, qbittorrent, qview, rustdesk, syncplay).
    • Updated OrcaSlicer to pull from its official repository.
    • Updated qView nightly distribution source to GitHub releases.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

Walkthrough

Nine Scoop package manifest files were updated to refactor version-checking logic from inline PowerShell Invoke-RestMethod calls with error handling to a two-step approach: explicit checkver.url fields paired with simplified scripts that parse pre-fetched JSON via $page. Two files also include repository or download URL updates.

Changes

Cohort / File(s) Summary
Core Refactoring
bucket/goneovim-nightly.json, bucket/ipfilter-nightly.json, bucket/lapce-nightly.json, bucket/prismlauncher-git.json, bucket/rustdesk-nightly.json, bucket/syncplay-beta.json
Moved version-check URLs into dedicated checkver.url fields and simplified scripts to parse $page JSON instead of calling Invoke-RestMethod inline. Removed try/catch error-handling wrappers, allowing failures to propagate. Same timestamp/data extraction logic preserved.
Extended Refactoring
bucket/qbittorrent-nightly.json
Added checkver.url for workflow API; refactored script to parse $page JSON for workflow run ID while separately fetching YAML for dependency version. Removed inline try/catch wrapper.
Repository & Download Updates
bucket/orcaslicer-nightly.json
Updated repository ownership from SoftFever/OrcaSlicer to OrcaSlicer/OrcaSlicer across homepage, download URLs, and API endpoints. Simplified checkver.script from try/catch array to single timestamp expression.
Download & Version-Check Overhaul
bucket/qview-nightly.json
Migrated download sources from nightly.link workflow URLs to GitHub releases URLs for all architectures; updated corresponding hash values. Added checkver.url for workflow API and simplified script to parse $page JSON, removing inline Invoke-RestMethod and try/catch.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

review-needed

Poem

🐰 Hops of joy through manifest lands,
URLs unfurled, no more command demands,
Parsing from $page so neat and clean,
Errors gone with try-catch unseen,
Simpler scripts, the future's bright!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete; it lacks issue linkage, context for why changes are needed, and detailed explanation of the changes. Add issue numbers (Closes/Relates #XXXX), provide motivation for the changes, and describe the technical rationale for removing try-catch blocks.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the primary change: removing redundant try-catch blocks from checkver logic across multiple manifest files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-checkver

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

All changes look good.

Wait for review from human collaborators.

goneovim-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ipfilter-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

lapce-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

orcaslicer-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

prismlauncher-git

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

qbittorrent-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

qview-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

rustdesk-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

syncplay-beta

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/prismlauncher-git.json`:
- Around line 85-86: Add a guard before indexing workflow_runs[0] to avoid
exceptions when no runs are returned: after converting JSON into $workflows
check that $workflows.workflow_runs is an array with length > 0 and that
workflow_runs[0].head_sha exists before assigning $fullSha; if the guard fails,
emit the expected Scoop checkver failure pattern (error 'no workflow runs
found'; break) so failures are deterministic and match checkver.script
expectations.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b8ac7345-0cde-45ab-bba9-ea238bb212d1

📥 Commits

Reviewing files that changed from the base of the PR and between f8f4244 and 4493c14.

📒 Files selected for processing (9)
  • bucket/goneovim-nightly.json
  • bucket/ipfilter-nightly.json
  • bucket/lapce-nightly.json
  • bucket/orcaslicer-nightly.json
  • bucket/prismlauncher-git.json
  • bucket/qbittorrent-nightly.json
  • bucket/qview-nightly.json
  • bucket/rustdesk-nightly.json
  • bucket/syncplay-beta.json

Comment thread bucket/prismlauncher-git.json
@z-Fng z-Fng merged commit bff978d into master Apr 7, 2026
6 checks passed
@z-Fng z-Fng deleted the fix-checkver branch April 7, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant