(chore): Clean up redundant try-catch blocks in checkver#2794
Conversation
WalkthroughNine Scoop package manifest files were updated to refactor version-checking logic from inline PowerShell Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All changes look good. Wait for review from human collaborators. goneovim-nightly
ipfilter-nightly
lapce-nightly
orcaslicer-nightly
prismlauncher-git
qbittorrent-nightly
qview-nightly
rustdesk-nightly
syncplay-beta
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/prismlauncher-git.json`:
- Around line 85-86: Add a guard before indexing workflow_runs[0] to avoid
exceptions when no runs are returned: after converting JSON into $workflows
check that $workflows.workflow_runs is an array with length > 0 and that
workflow_runs[0].head_sha exists before assigning $fullSha; if the guard fails,
emit the expected Scoop checkver failure pattern (error 'no workflow runs
found'; break) so failures are deterministic and match checkver.script
expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b8ac7345-0cde-45ab-bba9-ea238bb212d1
📒 Files selected for processing (9)
bucket/goneovim-nightly.jsonbucket/ipfilter-nightly.jsonbucket/lapce-nightly.jsonbucket/orcaslicer-nightly.jsonbucket/prismlauncher-git.jsonbucket/qbittorrent-nightly.jsonbucket/qview-nightly.jsonbucket/rustdesk-nightly.jsonbucket/syncplay-beta.json
Benefit from:
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Release Notes