freerdp-nightly: Add version 3.24.3-dev0-1961.5bac12b73#2792
freerdp-nightly: Add version 3.24.3-dev0-1961.5bac12b73#2792z-Fng merged 2 commits intoScoopInstaller:masterfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughAdds a new FreeRDP nightly package manifest that defines artifacts for 32/64-bit Windows, extraction and installed binaries, and an automated checkver/autoupdate routine querying Jenkins and GitHub to construct dynamic version strings. Changes
Sequence Diagram(s)sequenceDiagram
participant Manifest
participant JenkinsAPI
participant GitHubRaw
participant Downloader
Manifest->>JenkinsAPI: GET /job/.../lastSuccessfulBuild/api/json
JenkinsAPI-->>Manifest: build number & commit SHA
Manifest->>GitHubRaw: GET /raw/{commit}/cmake/GetProjectVersion.cmake
GitHubRaw-->>Manifest: file contents
Manifest->>Manifest: extract RAW_VERSION_STRING + format version
Manifest->>Downloader: construct CI ZIP URL(s) and fetch artifacts
Downloader-->>Manifest: ZIP files (for 32/64-bit)
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@bucket/freerdp-nightly.json`:
- Around line 30-33: The error handling in the checkver PowerShell snippet uses
"break" after reporting an error for missing $sha and for a failed
$versionMatch, which can silently terminate the runspace; update both
occurrences to use "throw" so the error is propagated (i.e., replace the
post-error "break" statements following the $sha check and the
$versionMatch.Success check that parses GetProjectVersion.cmake into
$cmake/$versionMatch with "throw" to properly raise exceptions).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 75610f81-1567-4467-88df-64b169242f0a
📒 Files selected for processing (1)
bucket/freerdp-nightly.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. freerdp-nightly
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. freerdp-nightly
|
https://www.freerdp.com/
Notes:
Command-line output is currently not working for
wfreerdpand SDL clients. I have opened a PR on the upstream repo to fix this: fix: console output on Windows client FreeRDP/FreeRDP#12573Use conventional PR title:
<manifest-name[@version]|chore>: <general summary of the pull request>I have read the Contributing Guide
Summary by CodeRabbit