Skip to content

freerdp-nightly: Add version 3.24.3-dev0-1961.5bac12b73#2792

Merged
z-Fng merged 2 commits intoScoopInstaller:masterfrom
sitiom:freerdp-nightly
Apr 7, 2026
Merged

freerdp-nightly: Add version 3.24.3-dev0-1961.5bac12b73#2792
z-Fng merged 2 commits intoScoopInstaller:masterfrom
sitiom:freerdp-nightly

Conversation

@sitiom
Copy link
Copy Markdown
Contributor

@sitiom sitiom commented Apr 6, 2026

https://www.freerdp.com/

Notes:

Summary by CodeRabbit

  • New Features
    • Added a FreeRDP nightly package for Windows (32-bit and 64-bit) with preconfigured extraction and installation of executables.
    • Built-in automated version checking and auto-update support that tracks latest CI builds and derives combined version identifiers for nightly releases.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4a6d1dde-c3f6-40e5-aab3-153c4e785c69

📥 Commits

Reviewing files that changed from the base of the PR and between b48ab28 and 01acbb1.

📒 Files selected for processing (1)
  • bucket/freerdp-nightly.json
✅ Files skipped from review due to trivial changes (1)
  • bucket/freerdp-nightly.json

Walkthrough

Adds a new FreeRDP nightly package manifest that defines artifacts for 32/64-bit Windows, extraction and installed binaries, and an automated checkver/autoupdate routine querying Jenkins and GitHub to construct dynamic version strings.

Changes

Cohort / File(s) Summary
FreeRDP Nightly Package Manifest
bucket/freerdp-nightly.json
New manifest adding a nightly package: metadata (description, homepage, license), architecture-specific CI ZIP URLs and hashes, extract_dir, enumerated bin executables, a checkver routine that queries Jenkins for last successful build and fetches GetProjectVersion.cmake from the corresponding GitHub commit to extract RAW_VERSION_STRING, and an autoupdate template for future artifacts.

Sequence Diagram(s)

sequenceDiagram
    participant Manifest
    participant JenkinsAPI
    participant GitHubRaw
    participant Downloader

    Manifest->>JenkinsAPI: GET /job/.../lastSuccessfulBuild/api/json
    JenkinsAPI-->>Manifest: build number & commit SHA
    Manifest->>GitHubRaw: GET /raw/{commit}/cmake/GetProjectVersion.cmake
    GitHubRaw-->>Manifest: file contents
    Manifest->>Manifest: extract RAW_VERSION_STRING + format version
    Manifest->>Downloader: construct CI ZIP URL(s) and fetch artifacts
    Downloader-->>Manifest: ZIP files (for 32/64-bit)
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 Nights hum with builds and light,

I hop through Jenkins, swift and bright.
SHA crumbs and versions in my paw,
Packaging joy with gentle awe.
FreeRDP dreams in code I saw. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the conventional format 'freerdp-nightly: Add version 3.24.3-dev0-1961.5bac12b73' and clearly describes the main change: adding a new manifest with a specific version.
Description check ✅ Passed The description includes the required conventional PR title checkbox (checked), confirmation of reading the Contributing Guide (checked), and relevant context about upstream issues. However, it lacks the optional issue reference (Closes/Relates #XXXX) section.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/freerdp-nightly.json`:
- Around line 30-33: The error handling in the checkver PowerShell snippet uses
"break" after reporting an error for missing $sha and for a failed
$versionMatch, which can silently terminate the runspace; update both
occurrences to use "throw" so the error is propagated (i.e., replace the
post-error "break" statements following the $sha check and the
$versionMatch.Success check that parses GetProjectVersion.cmake into
$cmake/$versionMatch with "throw" to properly raise exceptions).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 75610f81-1567-4467-88df-64b169242f0a

📥 Commits

Reviewing files that changed from the base of the PR and between 1e781e6 and b48ab28.

📒 Files selected for processing (1)
  • bucket/freerdp-nightly.json

Comment thread bucket/freerdp-nightly.json
@sitiom
Copy link
Copy Markdown
Contributor Author

sitiom commented Apr 6, 2026

/verify

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

All changes look good.

Wait for review from human collaborators.

freerdp-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Comment thread bucket/freerdp-nightly.json Outdated
@sitiom sitiom changed the title freerdp-nightly: Add version 3.24.3-dev0-48978e421 freerdp-nightly: Add version 3.24.3-dev0-1961.5bac12b73 Apr 7, 2026
@sitiom
Copy link
Copy Markdown
Contributor Author

sitiom commented Apr 7, 2026

/verify

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

All changes look good.

Wait for review from human collaborators.

freerdp-nightly

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

Copy link
Copy Markdown
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit b60e2d1 into ScoopInstaller:master Apr 7, 2026
3 checks passed
@sitiom sitiom deleted the freerdp-nightly branch April 7, 2026 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants