vmware-horizon-client-np: Update to version 2603, rename to Omnissa#580
vmware-horizon-client-np: Update to version 2603, rename to Omnissa#580tie-ling wants to merge 3 commits intoScoopInstaller:masterfrom
Conversation
WalkthroughAdded a new Omnissa Horizon Client Windows package manifest and removed the previous VMware Horizon Client manifest; the new manifest includes version, metadata, dependencies, 64-bit installer URL and SHA256, installer steps, binary and shortcut mapping. ChangesPackage Manifest Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/omnissa-horizon-client-np.json (1)
1-34: ⚖️ Poor tradeoffAdd
checkverandautoupdatefor maintainability.Without these fields, future version bumps require fully manual manifest edits. Given the structured download URL (
CART27FQ1_WIN_2603→ build-specific path, plus the version in the filename), this may require a checkver URL pointing to Omnissa's release notes or download API. Even a simplecheckverpointing to the download page would prevent stale manifests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/omnissa-horizon-client-np.json` around lines 1 - 34, Add a checkver and autoupdate block to the manifest so future version bumps are automatic: use the existing "version" field as the target to compare and derive new versions from the vendor release page (refer to "homepage") or the download page that lists builds, and map autoupdate to the "architecture"."64bit"."url" pattern and the EXE/MSI filename used in "installer"."script" (e.g., the CART27FQ1_WIN_2603 token and the Omnissa-Horizon-Client-<version>.exe pattern) so the updater can replace the version string and update the download URL/hash automatically. Ensure the autoupdate template updates both the top-level "version" and the "architecture.64bit.url" (and optionally the MSI extract name in "installer.script") and include a checkver URL that points to Omnissa’s releases/downloads page or API to detect new versions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/omnissa-horizon-client-np.json`:
- Line 4: Update the JSON "homepage" field value to point to the official
product page instead of the cloud service domain: replace the current value for
the "homepage" key (currently "https://omnissahorizon.com") with
"https://horizon.saia.com/". Locate the "homepage" key in the
omnissa-horizon-client-np.json content and change only its string value,
preserving the surrounding JSON formatting and trailing comma.
---
Nitpick comments:
In `@bucket/omnissa-horizon-client-np.json`:
- Around line 1-34: Add a checkver and autoupdate block to the manifest so
future version bumps are automatic: use the existing "version" field as the
target to compare and derive new versions from the vendor release page (refer to
"homepage") or the download page that lists builds, and map autoupdate to the
"architecture"."64bit"."url" pattern and the EXE/MSI filename used in
"installer"."script" (e.g., the CART27FQ1_WIN_2603 token and the
Omnissa-Horizon-Client-<version>.exe pattern) so the updater can replace the
version string and update the download URL/hash automatically. Ensure the
autoupdate template updates both the top-level "version" and the
"architecture.64bit.url" (and optionally the MSI extract name in
"installer.script") and include a checkver URL that points to Omnissa’s
releases/downloads page or API to detect new versions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e1f70972-71f0-4f36-a1e2-b338a06fe653
📒 Files selected for processing (2)
bucket/omnissa-horizon-client-np.jsonbucket/vmware-horizon-client-np.json
💤 Files with no reviewable changes (1)
- bucket/vmware-horizon-client-np.json
| { | ||
| "version": "2603-8.18.0-24230927696", | ||
| "description": "Omnissa Horizon Client for Windows allows you to connect to your Omnissa Horizon virtual desktop.", | ||
| "homepage": "https://omnissahorizon.com", |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the official product homepage URL for Omnissa Horizon Client (not the cloud login, but the marketing/download page)?
💡 Result:
Official product (marketing/download) homepage URL for Omnissa Horizon Client: https://horizon.saia.com/ [1] This page presents “Install Omnissa Horizon Client” and provides “Click Here to Download Omnissa Horizon Client,” while offering client options (e.g., Chrome, Web Client) rather than a cloud login flow. [1]
Citations:
Update homepage URL to the official Omnissa Horizon Client product page.
The current homepage https://omnissahorizon.com points to the cloud service domain. The official product page with installation and download options is https://horizon.saia.com/. Update line 4 to reference this instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@bucket/omnissa-horizon-client-np.json` at line 4, Update the JSON "homepage"
field value to point to the official product page instead of the cloud service
domain: replace the current value for the "homepage" key (currently
"https://omnissahorizon.com") with "https://horizon.saia.com/". Locate the
"homepage" key in the omnissa-horizon-client-np.json content and change only its
string value, preserving the surrounding JSON formatting and trailing comma.
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with omnissa-horizon-client-np
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. omnissa-horizon-client-np
|
There was a problem hiding this comment.
♻️ Duplicate comments (1)
bucket/omnissa-horizon-client-np.json (1)
4-4:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUse a stable product homepage URL instead of the portal redirect domain.
https://omnissahorizon.comcurrently redirects into a webclient-style endpoint; for package metadata, a stable Omnissa product/corporate page is safer and clearer for users.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/omnissa-horizon-client-np.json` at line 4, The package metadata currently sets the "homepage" field to a URL that redirects (the "homepage" key in omnissa-horizon-client-np.json); replace that value with a stable product or corporate landing page URL (a non-redirecting Omnissa product/corporate page) and verify the chosen URL resolves directly (no HTTP redirects) before committing so consumers see a stable, human-readable homepage.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@bucket/omnissa-horizon-client-np.json`:
- Line 4: The package metadata currently sets the "homepage" field to a URL that
redirects (the "homepage" key in omnissa-horizon-client-np.json); replace that
value with a stable product or corporate landing page URL (a non-redirecting
Omnissa product/corporate page) and verify the chosen URL resolves directly (no
HTTP redirects) before committing so consumers see a stable, human-readable
homepage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 4d434686-b625-4ef7-8c12-3e2aeb662d00
📒 Files selected for processing (1)
bucket/omnissa-horizon-client-np.json
1 participant
The program has been renamed to omnissa horizon client. The old download links are now invaild and have been updated.
@beargle @rasa
Closes #XXXX
Relates to #XXXX
Summary by CodeRabbit
New Features
Chores