mpv-git: Migrate 64-bit builds to v3#11123
Open
brian6932 wants to merge 5 commits intoScoopInstaller:masterfrom
Open
mpv-git: Migrate 64-bit builds to v3#11123brian6932 wants to merge 5 commits intoScoopInstaller:masterfrom
brian6932 wants to merge 5 commits intoScoopInstaller:masterfrom
Conversation
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. mpv-git
|
Contributor
|
Name Modified Downloads/Week
I Totally like that. |
Member
|
versions bucket. |
1 task
jasongodev
suggested changes
May 10, 2023
Contributor
jasongodev
left a comment
There was a problem hiding this comment.
I suggest the following to be done before I approve this request:
- An old version must be placed in the Versions bucket.
- A note in this bucket saying that certain CPUs will not run and they should download the one in Versions bucket instead.
Contributor
|
@jasongodev mpv-v3 hasn't released a stable version yet, so I invite you to review this pr: ScoopInstaller/Versions#1187 |
1 task
brian6932
added a commit
to brian6932/Versions
that referenced
this pull request
Oct 1, 2023
Contributor
Author
|
Potentially, I could PR more granular arch detection in ScoopInstaller/Scoop, to have separate archs called |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may break compatibility with older CPUs (to my understanding CPUs from the past 10 years should work), so it's understandable if this is not wanted. Maybe versions, or a separate
mpv-git-v3in extras is a better place for something like this.README.rstmarkdown converted:Difference between x86_64 and x86_64-v3
x86_64-v3 builds have these instructions enabled by default:
CPUs which don't have these features will fail to launch the x86_64-v3 build