Refactor architecture#5
Conversation
… for project and goal management
|
Visit the preview URL for this PR (updated for commit 88516a3): https://my-productivity-hub-5a3ba--pr5-refactor-architectur-b0ltxmci.web.app (expires Fri, 24 Apr 2026 10:49:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4ef75aef15076a8cc05555b91f31935d9a13db8e |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a custom project type feature in the sidebar, allowing users to define their own tags, and enhances the Gemini API service by adding retry logic for 503 Service Unavailable errors. Review feedback highlights a logic error in the retry mechanism where exhausting retries for network errors could result in an undefined return value instead of an error, and suggests improving accessibility for the new custom tag input field by adding an aria-label.
| <input | ||
| type="text" | ||
| value={newProjectCustomType} | ||
| onChange={(e) => setNewProjectCustomType(e.target.value)} | ||
| placeholder="Enter custom tag" | ||
| className="w-full bg-gray-700 border border-gray-600 rounded-md px-2 py-1 text-sm focus:outline-none focus:ring-2 focus:ring-blue-500" | ||
| /> |
There was a problem hiding this comment.
The custom tag input field lacks an associated label or an aria-label. Adding an aria-label improves accessibility for users navigating the application with screen readers, as there is no visible text label for this input.
1 participant
adding custom tag