feat: add terminalAutoShow setting for auto-showing terminal on command execution#12278
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
feat: add terminalAutoShow setting for auto-showing terminal on command execution#12278roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
…nd execution Adds a new opt-in setting "terminalAutoShow" that: - When using VS Code terminal (shell integration enabled): automatically shows the terminal panel when Roo runs a command - When using Inline Terminal (execa mode): auto-expands command output in the chat so users can always see what is happening Addresses options (a) and (c) from Issue #12277. Changes: - packages/types: add terminalAutoShow to schema + ExtensionState - src/core/tools/ExecuteCommandTool: conditionally call terminal.show() - src/core/webview/ClineProvider: thread setting through state - webview-ui: add checkbox in TerminalSettings, auto-expand in CommandExecution - i18n: add English strings for the new setting
2 tasks
YousefBZo
approved these changes
May 6, 2026
YousefBZo
left a comment
There was a problem hiding this comment.
I've reviewed all the changes in the PR, and I must say the implementation is perfect! You've addressed everything from the auto-focus in the VS Code terminal to the auto-expansion in the chat UI. The settings UI also looks very clean and the descriptions are clear. Thank you for making this happen—it's going to be a great addition to Roo Code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12277
Description
This PR attempts to address Issue #12277 by adding a new opt-in
terminalAutoShowsetting. Feedback and guidance are welcome.Implementation (options a + c as approved by the reporter):
terminalAutoShowis on,terminal.show(true)is called to reveal the terminal panel (preserving editor focus). When off, the terminal panel is no longer auto-shown.terminalAutoShowis on, the command output in the chat is auto-expanded so users can always see command progress. This complements the existing behavior where execa output is already expanded by default.Changes across the stack:
packages/types/src/global-settings.ts-- AddedterminalAutoShowto the zod schema with defaultfalsepackages/types/src/vscode-extension-host.ts-- Added toExtensionStatepick typesrc/core/webview/ClineProvider.ts-- Thread setting through state retrievalsrc/core/tools/ExecuteCommandTool.ts-- Conditionally callterminal.show(true)only when enabledwebview-ui/src/context/ExtensionStateContext.tsx-- Added state + setterwebview-ui/src/components/settings/TerminalSettings.tsx-- Added checkbox in Basic settingswebview-ui/src/components/settings/SettingsView.tsx-- Pass prop throughwebview-ui/src/components/chat/CommandExecution.tsx-- Auto-expand output when enabledwebview-ui/src/i18n/locales/en/settings.json-- English i18n stringsTest Procedure
Pre-Submission Checklist
Documentation Updates
No external documentation changes needed -- the setting is described in the UI itself.
Interactively review PR in Roo Code Cloud