test: separate Jest and nyc coverage outputs to fix Codecov upload#40083
test: separate Jest and nyc coverage outputs to fix Codecov upload#40083
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #40083 +/- ##
===========================================
- Coverage 70.18% 70.13% -0.05%
===========================================
Files 3278 3278
Lines 116631 116539 -92
Branches 20689 20311 -378
===========================================
- Hits 81852 81731 -121
- Misses 31489 31535 +46
+ Partials 3290 3273 -17
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Jest and nyc were both writing to `coverage/lcov.info`, causing nyc to overwrite Jest output. Now each writes to its own subdirectory and the codecov action explicitly uploads both files. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The codecov action was auto-discovering coverage files from all monorepo packages, some of which caused "Unusable report" errors. Now only the explicit Jest and nyc lcov files from apps/meteor are uploaded. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
nyc generates lcov paths relative to apps/meteor/ (e.g. SF:server/lib/foo.ts) but Codecov needs them relative to the repo root (e.g. SF:apps/meteor/server/lib/foo.ts). Using sed to prefix paths after generation is safer than global codecov.yml fixes which could interfere with ee/packages/ paths from other uploads. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds a second codecov upload step with a 'packages' flag that auto-discovers coverage from all packages while excluding apps/meteor coverage (which is already uploaded under the 'unit' flag). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Temporary step to verify lcov paths before codecov upload. Will be removed once the unusable report issue is resolved. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4531845 to
d903792
Compare
🔴 Layne — 1 finding(s)Found 1 issue(s): 1 high. |
Jest and nyc were both writing to
coverage/lcov.info, causing nyc to overwrite Jest output. Now each writes to its own subdirectory and the codecov action explicitly uploads both files.Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments