Add Windows on ARM (ARM64) CI support#605
Draft
stefanatwork wants to merge 7 commits into
Draft
Conversation
stefanatwork
changed the title
Agent-Logs-Url: https://github.com/RenderKit/embree/sessions/ead49f65-088a-401f-b6ff-a821bf4b5b25 Co-authored-by: stefanatwork <93931354+stefanatwork@users.noreply.github.com>
Agent-Logs-Url: https://github.com/RenderKit/embree/sessions/71a93d2a-2cfa-4e53-ad36-40765438ddee Co-authored-by: stefanatwork <93931354+stefanatwork@users.noreply.github.com>
Copilot
AI
changed the title
Windows on ARM CI workflow
Add Windows on ARM (ARM64) CI support
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embree had no CI coverage for Windows on ARM. MSVC doesn't define
__aarch64__(it uses_M_ARM64/_M_ARM64EC), causing ARM64-specific code paths—includingsse2neon.h—to silently miscompile or fail at runtime.Changes
common/sys/platform.h— normalize ARM64 detection: define__aarch64__when_M_ARM64or_M_ARM64ECis set, so all downstream code depending on__aarch64__works under MSVCcommon/simd/arm/sse2neon.h— replace the GCC-only#warningwith#pragma messageunder_MSC_VERto fix the build error caused by MSVC treating#warningas an error.github/workflows/public.continuous.yml— add awindows-11-armCI job using a self-hosted ARM runner; fixEMBREE_TUTORIALS=OFF→ONso the tutorial build is actually exercised in CI