Open
Conversation
raz-mon
reviewed
Mar 3, 2026
Collaborator
There was a problem hiding this comment.
The state of what branch is this?
If not master, then this probably should not be merged to master yet, until it is merged to Redis master.
Perhaps have a side-branch in the mean-time?
Nonetheless, we should align this with master's header (not sure if this was the case)
raz-mon
reviewed
Mar 3, 2026
Comment on lines
-113
to
-116
| /// Initialize RedisModuleAPI without register as a module. | ||
| pub fn init_api(ctx: &Context) { | ||
| unsafe { crate::raw::Export_RedisModule_InitAPI(ctx.ctx) }; | ||
| } |
Collaborator
There was a problem hiding this comment.
Why was this and others removed?
Collaborator
Author
There was a problem hiding this comment.
these APIs seem not to be there in the redismodule.h
chesedo
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.