Add CLIENT SETINFO support to identify spark-redis connections in Redis server#401
Open
viktoriya-kutsarova wants to merge 1 commit intoRedisLabs:masterfrom
Open
Add CLIENT SETINFO support to identify spark-redis connections in Redis server#401viktoriya-kutsarova wants to merge 1 commit intoRedisLabs:masterfrom
viktoriya-kutsarova wants to merge 1 commit intoRedisLabs:masterfrom
Conversation
Author
|
The tests are failing because the server version in the CI pipeline is Redis 6.0.10, so setting the library name and version is expected to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements client library identification on Redis servers using the CLIENT SETINFO command. When connections are established, the connector now automatically registers itself with Redis, allowing server administrators to identify and monitor spark-redis client connections.
Key Changes
RedisClientLibraryInfoobject to encapsulate library name and version information extracted from the package manifestSparkRedisJedisFactoryextendingJedisFactoryto send CLIENT SETINFO at connection creation time (not on every pool borrow)ConnectionPoolTest) to verify client info registration and connection pooling behaviorClient Info Format
jedis(spark-redis_v{version})- version extracted from JAR manifest or "unknown" in development3.9.0)