fixed binary serde issue#252
Open
comphead wants to merge 1 commit intoRedisLabs:masterfrom
Open
Conversation
fe2s
suggested changes
Jul 22, 2020
| val valuesArray: Array[Any] = SerializationUtils.deserialize(value) | ||
| new GenericRowWithSchema(valuesArray, schema) | ||
| // Aligning column positions with what Catalyst expecting | ||
| val alignedSchema = SparkUtils.alignSchemaWithCatalyst(schema, requiredColumns) |
Contributor
There was a problem hiding this comment.
We can optimize it by creating alignedSchema once for all rows. To achieve it I guess we will need to change the decodeRow() signature by adding a new parameter, it will have two schemas: requiredSchema and persistedSchema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed serde issue when reading/writing a dataframe in binary mode. Please consider next example
That fails with Caused by: java.lang.IllegalArgumentException: The value (1) of the type (java.lang.String) cannot be converted to an array of structstr0:string,id0:int
The reason of that is:
The proposed fix makes correct attr order for binary deserialized value
Also please note, without provided schema its difficult to deserealize the binary value as we dont have an initial order. Added warning for that