Skip to content

feat: Add support for going to the beginning of a block #9629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbrudastyy wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Add support for going to the beginning of a block #9629

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6b0ada
feat: Add support for going to the beginning of a block
KotovBogdan Mar 11, 2026
283f505
feat: Add check is block fully in bounds (#9628)
KotovBogdan Mar 19, 2026
28c9d36
chore: Update the centering on the block by checking the block positi…
KotovBogdan Mar 19, 2026
afb67ab
chore: Add test centerOnBlock when block partially out of bounds (#9628)
KotovBogdan Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/blockly/core/workspace_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,8 +1987,9 @@
*
* @param id ID of block center on.
* @param blockOnly True to center only on the block itself, not its stack.
* @param centerOnBlockStart It is correct to center only on the block itself at its beginning.
*/
centerOnBlock(id: string | null, blockOnly?: boolean) {
centerOnBlock(id: string | null, blockOnly?: boolean, centerOnBlockStart?: boolean) {

Check failure on line 1992 in packages/blockly/core/workspace_svg.ts

View workflow job for this annotation

GitHub Actions / lint 

Replace `id:·string·|·null,·blockOnly?:·boolean,·centerOnBlockStart?:·boolean` with `⏎····id:·string·|·null,⏎····blockOnly?:·boolean,⏎····centerOnBlockStart?:·boolean,⏎··`
if (!this.isMovable()) {
console.warn(
'Tried to move a non-movable workspace. This could result' +
Expand All @@ -2010,7 +2011,9 @@
: block.getHeightWidth();

// Find the enter of the block in workspace units.
const blockCenterY = xy.y + heightWidth.height / 2;
const blockCenterY = centerOnBlockStart
? xy.y
: xy.y + heightWidth.height / 2;

// In RTL the block's position is the top right of the block, not top left.
const multiplier = this.RTL ? -1 : 1;
Expand Down
Loading