Add Add-Opens to JAR manifest#5983
Draft
kwvanderlinde wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
code-maintenance
Collaborator
Author
|
Keeping this as a draft for now as it should be merged after the other JAR improvement PRs. |
This means that running the JAR via `java -jar` will not require a bunch of `--add-opens` flags to be manually added on the command line. The set of modules is defined in one list, then: - Compiled into the JAR/shadow JAR manifest's `Add-Opens` list - Added as `--add-opens` command line options for running from Gradle or the JPackage.
kwvanderlinde
force-pushed
the
refactor/5975-run-jar-without-add-opens
branch
from
12afad4 to
508650f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Resolves #5975
Description of the Change
Includes an
Add-Opensattribute in the JAR manifest files. This means the user does not have to open these modules via--add-openson the command line when running MT viajava -jar ${jarFile}. Note: theAdd-Opensattributed isn't documented until Java 23 but is functional at least as far back as Java 21The set of modules is defined in one list so that the shadow JAR, regular JAR, gradle
:runtask, and jpackage image all open the same set of modules.Opening
java.desktop/com.sun.java.swing.plaf.windowswas obsolete and so has been removed.Possible Drawbacks
Should be none
Documentation Notes
N/A
Release Notes
Add-Opensoptions to the released JAR manifests so that--add-openscommand-line options are not required when running the JAR.This change is