Remove support for -v option#5980
Open
kwvanderlinde wants to merge 1 commit into
Open
Conversation
The flag is still defined so the application can start with existing command line options that specific the version. However, a warning will be logged, and the provided version number will be ignored.
github-actions
Bot
added
the
code-maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Resolves #5973
Description of the Change
This removes support for the
-vcommand line option that overrides the built-in version. The option itself is still registered (so that existing scripts can run new JARs), but a warning is logged to explain that the version number is no longer respected.This has one change in behaviour for development runs (e.g.,
gradlew run). Tthe splash screen will now show the version as "DEVELOPMENT" rather than "0.0.1" since it is no longer provided in the application arguments and there is no JAR manifest from which to pull aImplementation-Version.Possible Drawbacks
Can't directly control the version details anymore.
Documentation Notes
The
-vcommand line option no longer has an effect.Release Notes
-vcommand line parameter.This change is