Skip to content

Remove redundant JVM options#5979

Open
kwvanderlinde wants to merge 1 commit into
RPTools:developfrom
kwvanderlinde:refactor/5971-remove-redundant-jvm-options
Open

Remove redundant JVM options#5979
kwvanderlinde wants to merge 1 commit into
RPTools:developfrom
kwvanderlinde:refactor/5971-remove-redundant-jvm-options

Conversation

@kwvanderlinde

@kwvanderlinde kwvanderlinde commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Identify the Bug or Feature request

Resolves #5971

Description of the Change

Removes options -Dfile.encoding=UTF-8 and -XX:+ShowCodeDetailsInExceptionMessages as these are already the default behaviour in recent Java versions.

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

  • Removed some unnecessary JVM arguments from the build.

This change is Reviewable

Both these options are now the default behaviour and so do not need to be provided.
@kwvanderlinde kwvanderlinde self-assigned this Jun 18, 2026
@github-actions github-actions Bot added the code-maintenance Adding/editing javadocs, unit tests, formatting. label Jun 18, 2026
@kwvanderlinde kwvanderlinde moved this from Todo to Awaiting-Review in MapTool 1.19 Jun 18, 2026
@FullBleed

Copy link
Copy Markdown

I use a java option that I never see anyone else use in order to control where the .openjfx dir is created -Djavafx.cachedir. I hate stuff being written to my User root directory. That option isn't being caught in the crossfire here is it?

@kwvanderlinde

Copy link
Copy Markdown
Collaborator Author

I use a java option that I never see anyone else use in order to control where the .openjfx dir is created -Djavafx.cachedir. I hate stuff being written to my User root directory. That option isn't being caught in the crossfire here is it?

@FullBleed Nothing under #5970 will prevent standard configurations such as that one. It will only make command line options unnecessary in vanilla cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-maintenance Adding/editing javadocs, unit tests, formatting.

Projects

Status: Awaiting-Review

Development

Successfully merging this pull request may close these issues.

[Maintenance]: Remove redundant JVM options

2 participants