Fix NPE for SocketConnection#5976
Open
kwvanderlinde wants to merge 3 commits into
Open
Conversation
…Connection and WebRTCConnection as each is only used in one place
a7570b4 to
d625762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #5558
Description of the Change
More clearly distinguishes the "connected" state from other states for
SocketConnection.socket,send, andreceiveare only accessed ifsocketis first checked to not benull.hostNameandportare only accessed ifsocketis first checked to benull.Also refactored
AbstractConnectiona bit:readMessage()andwriteMessage()out ofAbstractConnectionintoSocketConnectionandWebRTCConnectionsince each one is specific to one of those.Possible Drawbacks
Shouldn't be any.
Documentation Notes
N/A
Release Notes
This change is