Skip to content

bugfix: ControlPortOverNL80211 to true for rk3326#2817

Open
sunshineinabox wants to merge 1 commit into
ROCKNIX:nextfrom
sunshineinabox:rk3326_fixdongles
Open

bugfix: ControlPortOverNL80211 to true for rk3326#2817
sunshineinabox wants to merge 1 commit into
ROCKNIX:nextfrom
sunshineinabox:rk3326_fixdongles

Conversation

@sunshineinabox
Copy link
Copy Markdown
Collaborator

Summary

  • What is the goal of this PR? Fixes SAE on RK3326 dongles (might apply to other devices)

Testing

  • How was this tested? (e.g. Built and tested on specific devices, manual testing steps, URLs for CI/CD build artifacts.)
  • Test results: (e.g. Screenshots, logs, performance metrics if applicable.)

Additional Context

  • Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on.)

AI Usage

While ROCKNIX doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? NO

@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 30, 2026

while this is a bugfix, it only targets usb dongles...
I'm concerned about breaking internal wifi of some RK3326...
with the iminent release comming, I'd advice to wait for next merge window

@sunshineinabox
Copy link
Copy Markdown
Collaborator Author

Okay no problem! I don't have a rk3326 device wiht internal wifi to test with.

@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 30, 2026

Okay no problem! I don't have a rk3326 device wiht internal wifi to test with.

ah may be that doesn't exists, not very versed in rk3326 (it's such a jungle)

@sunshineinabox
Copy link
Copy Markdown
Collaborator Author

I think there is a r36s variant (I think its on the same soc) but yea there are so many its impossible to know.

@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 30, 2026

still, it's also possible we fix one dongle, but break 2 others...
let's play it safe ?

@sunshineinabox
Copy link
Copy Markdown
Collaborator Author

I agree we can wait to merge I have a run going now I'll ask for people to try it once its done

@loki666
Copy link
Copy Markdown
Contributor

loki666 commented May 30, 2026

maybe @stolen has an advice here ?

@porschemad911
Copy link
Copy Markdown
Contributor

porschemad911 commented May 31, 2026

Odroid Go Advance rev 1.1 has internal wifi

I can test on mine when I get a chance.

@stolen
Copy link
Copy Markdown
Contributor

stolen commented May 31, 2026

IDK what this can affect. But we definitely have a bunch of weird fragile wi-fi drivers, and who knows if they are compatible with this

@sunshineinabox
Copy link
Copy Markdown
Collaborator Author

It’s actually the default value so should probably mark it false per device instead of the other way around. I do think waiting for the next merge window is the best move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants