Conversation
| version = "0.4.6" | ||
| authors = ["Lukas Devos <ldevos98@gmail.com>", "Jutho Haegeman <jutho.haegeman@ugent.be>"] | ||
| authors = ["Lukas Devos <lukas.devos@ugent.be>", "Jutho Haegeman <jutho.haegeman@ugent.be>"] | ||
| version = "0.5.0" |
There was a problem hiding this comment.
Does this count as a breaking change? I am not saying I definitely don't think it should be 0.5, but I also think that for downstream this should always be handled automatically by the CUDA compat, so should not end up breaking anyone's code
There was a problem hiding this comment.
Well, if I'm changing the name of a major dep, I'd always bump the minor version just as a matter of honour. But indeed compat probably protects us here... could go either way tbh
There was a problem hiding this comment.
Feel free to add your name to the authors list 😄 .
I agree that it is nice to have a minor version bump for this kind of change. That it counts as breaking because we are still at 0.x is something to live with. Maybe we should consider bringing these packages to the version "1" level.
There was a problem hiding this comment.
I would really like to add this back into Strided though, if we choose another breaking release for Strided at some point. (This is separate from this point, let's release like this for now!)
Before tagging, I also have an adapt extension locally, let me add that on top of this first
There was a problem hiding this comment.
Sorry I already tagged!!
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
3 participants
This should help a lot with load times (and is necessary for the corresponding
TensorOperations.jlchanges).