feat: Add example rows to ValidationError for all rule failures#286
feat: Add example rows to ValidationError for all rule failures#286Copilot wants to merge 11 commits into
ValidationError for all rule failures#286Conversation
…and examples Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
primary_key ValidationError
Oliver Borchert (borchero)
left a comment
There was a problem hiding this comment.
- Adjust the
format_rule_failuresmethod to optionally include examples. Possibly add a helper method toFailureInfoif that is helpful. - Do not only provide examples for primary key violations but for any type of validation
- Adjust the Rust plugin s.t. the same information is generated during lazy execution
…paths Co-authored-by: borchero <22455425+borchero@users.noreply.github.com>
Addressed in commit 462f8ce:
Example output: Note: string quotes differ slightly between eager (Python |
primary_key ValidationErrorValidationError for all rule failures
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## streamin #286 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 56 56
Lines 3427 3419 -8
==========================================
- Hits 3427 3419 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Copilot's code has been replaced
Motivation
Closes #282.
Changes
This PR adds a new option
max_failure_examplesto the config object. Users can set, for example,to show up to three failures for each failing rule whenever validation is run. Examples are shown both for lazy and eager validation.
Side note for reviewers: copilot was rather unhelpful here 😅