Skip to content

[codex] Apply audit remediation #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pigbibi merged 1 commit into from
Jun 10, 2026
Merged

[codex] Apply audit remediation #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,13 @@ on:
push:
pull_request:

permissions:
contents: read

jobs:
test:
runs-on: ubuntu-latest
timeout-minutes: 15
steps:
- uses: actions/checkout@v6
- uses: actions/setup-python@v6
Expand All @@ -16,4 +20,3 @@ jobs:
run: python -m pip install -e ".[test]"
- name: Run tests
run: python -m pytest -q

8 changes: 8 additions & 0 deletions .github/workflows/cross_repo_smoke.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,17 @@ on:
schedule:
- cron: "45 11 * * 6"

permissions:
contents: read

concurrency:
group: cross-repo-advisory-smoke-${{ github.ref_name }}
cancel-in-progress: false

jobs:
cross-repo-smoke:
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout advisor repository
uses: actions/checkout@v6
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/monthly_advisory_review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,17 @@ on:
schedule:
- cron: "20 13 1 * *"

permissions:
contents: read

concurrency:
group: monthly-advisory-review-${{ github.ref_name }}
cancel-in-progress: false

jobs:
build-monthly-review:
runs-on: ubuntu-latest
timeout-minutes: 45
steps:
- name: Checkout advisor repository
uses: actions/checkout@v6
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/publish_advisory_site.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,14 @@ permissions:
id-token: write


concurrency:
group: ${{ github.workflow }}-${{ github.ref_name }}
cancel-in-progress: false

jobs:
build-site:
runs-on: ubuntu-latest
timeout-minutes: 60
environment:
name: github-pages
url: ${{ steps.deployment.outputs.page_url }}
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/weekly_advisory_review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,17 @@ on:
schedule:
- cron: "30 12 * * 6"

permissions:
contents: read

concurrency:
group: weekly-advisory-review-${{ github.ref_name }}
cancel-in-progress: false

jobs:
build-review:
runs-on: ubuntu-latest
timeout-minutes: 45

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid timing out degraded market-data fallback runs

When this scheduled/manual workflow runs with MARKET_DATA_PROXY_URLS or a proxy pool containing even one unreachable proxy, the new 45-minute job cap can kill the run before it writes any advisory artifacts. The build keeps network market confirmation enabled with the default --market-max-symbols 80, and fetch_yahoo_bars_with_fallback tries the direct Yahoo request plus each proxy for every symbol with a 20s timeout, so a direct timeout plus one dead proxy is already about 80 * 2 * 20s (>53 minutes) before report generation and fallback/cache behavior can complete. Please either bound the proxy/symbol inputs in this workflow or set the job timeout above the worst bounded path.

Useful? React with 👍 / 👎.

steps:
- name: Checkout advisor repository
uses: actions/checkout@v6
Expand Down