Skip to content

[codex] Apply audit remediation#151

Merged
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610
Jun 10, 2026
Merged

[codex] Apply audit remediation#151
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • apply the 2026-06-10 audit remediation items
  • tighten GitHub workflow permissions, job timeouts, and scheduled/manual concurrency where applicable
  • add focused characterization or governance checks where this repository has runtime-facing changes

Validation

  • targeted local tests and lint checks were run before publishing
  • workflow governance scan passed across the remediation scope
  • git diff --check passed across the remediation scope

See local audit report: QuantStrategyLab-review-2026-06-10.md.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d615d4313a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sync:
name: Deploy / Sync ${{ matrix.target.label }} Cloud Run
runs-on: ubuntu-latest
timeout-minutes: 20

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Raise deploy job timeout above commit wait

When env sync is enabled and CLOUD_RUN_ENV_SYNC_WAIT_FOR_COMMIT is left at its default true value, this workflow's later wait step deliberately allows up to 1800 seconds before failing while it polls for the deployed commit (sync-cloud-run-env.yml lines 492-500). With the new job timeout capped at 20 minutes, GitHub can terminate the job before that existing 30-minute wait has a chance to complete, so slower but still-acceptable Cloud Run deployments will fail prematurely before env sync/scheduler steps run.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit cb3ef25 into main Jun 10, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/report-remediation-20260610 branch June 10, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant