Skip to content

[codex] Apply audit remediation#88

Merged
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610
Jun 10, 2026
Merged

[codex] Apply audit remediation#88
Pigbibi merged 1 commit into
mainfrom
codex/report-remediation-20260610

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • apply the 2026-06-10 audit remediation items
  • tighten GitHub workflow permissions, job timeouts, and scheduled/manual concurrency where applicable
  • add focused characterization or governance checks where this repository has runtime-facing changes

Validation

  • targeted local tests and lint checks were run before publishing
  • workflow governance scan passed across the remediation scope
  • git diff --check passed across the remediation scope

See local audit report: QuantStrategyLab-review-2026-06-10.md.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8f534d6de1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

monthly-publish:
if: github.ref_name != 'logs'
runs-on:
timeout-minutes: 60

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore the runner list under runs-on

In the monthly publish workflow, adding timeout-minutes at the same indentation as the empty runs-on: changes the YAML meaning: the runner labels are no longer assigned to runs-on and instead get folded into the timeout-minutes value (locally parsing this file yields runs-on: null and timeout-minutes: "60 - self-hosted - Linux - X64"). That makes the scheduled/manual monthly publish job invalid because GitHub Actions has no runner target and the timeout is not a number. Move timeout-minutes: 60 outside the runs-on block while keeping the self-hosted/Linux/X64 list under runs-on.

Useful? React with 👍 / 👎.

@Pigbibi Pigbibi merged commit b8d6f53 into main Jun 10, 2026
1 check passed
@Pigbibi Pigbibi deleted the codex/report-remediation-20260610 branch June 10, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant