Skip to content

Update della docs and minor edits to example#66

Merged
laurejt merged 1 commit intodevelopfrom
feature/update-della-doc
Apr 13, 2026
Merged

Update della docs and minor edits to example#66
laurejt merged 1 commit intodevelopfrom
feature/update-della-doc

Conversation

@laurejt
Copy link
Copy Markdown
Contributor

@laurejt laurejt commented Apr 9, 2026

Associated Issue(s): N/A

Changes in this PR

  • Renamed della-instructions.md to della-guide.md
  • Revised and expanded della-guide.md contents.
  • Minor edits to slurm example translage-della.slurm:
    • Small fixes to the slurm GPU configuration to align with Della documentation
    • Updated args validation so the exact number of input parameters must be specified

Reviewer Checklist

  • Check that della guide is correct and legible
  • Check that all links in the guide work
  • Confirm that the example script with the instructed updates runs for both CPU and GPU jobs.

@laurejt laurejt requested a review from tanhaow April 9, 2026 14:10
Copy link
Copy Markdown
Contributor

@tanhaow tanhaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

# Validate arguments
# ---------------------------------------------------------------------------
if [ -z "$1" ] || [ -z "$2" ] || [ -z "$3" ]; then
if [ "$#" -ne 3 ]; then
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@laurejt laurejt merged commit 5a5d2f6 into develop Apr 13, 2026
1 check passed
@laurejt laurejt deleted the feature/update-della-doc branch April 13, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants